Re: Review Request 111545: Port komain away from KParts

2013-10-18 Thread Friedrich W. H. Kossebau
, Friedrich W. H. Kossebau and Marijn Kruisselbrink. Bugs: 310310, 313482 and 313483 http://bugs.kde.org/show_bug.cgi?id=310310 http://bugs.kde.org/show_bug.cgi?id=313482 http://bugs.kde.org/show_bug.cgi?id=313483 Repository: calligra Description

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-10-16 Thread Friedrich W. H. Kossebau
/widgetutils/CMakeLists.txt bfe64ca sheets/CMakeLists.txt e0f4a02 stage/part/CMakeLists.txt 87df86c words/part/CMakeLists.txt 4e2650c Diff: http://git.reviewboard.kde.org/r/111306/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Review Request 113261: Port KoRdfFoaF KoRdfCalendarEvent to Akonadi

2013-10-15 Thread Friedrich W. H. Kossebau
CMakeLists.txt 41d8ad6 libs/rdf/CMakeLists.txt bd29ead libs/rdf/KoRdfCalendarEvent.h 87e21b7 libs/rdf/KoRdfCalendarEvent.cpp 710e9be Diff: http://git.reviewboard.kde.org/r/113261/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 112573: fix support for thumbnailer Co.

2013-10-03 Thread Friedrich W. H. Kossebau
/extensions/dockers/flipbook/flipbookdocker_dock.cpp 49cf62a Diff: http://git.reviewboard.kde.org/r/112573/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 112573: fix support for thumbnailer Co.

2013-09-06 Thread Friedrich W. H. Kossebau
/112573/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111545: Port komain away from KParts

2013-08-13 Thread Friedrich W. H. Kossebau
about a signal that is catched by the KoPart, which then does what is needed to present this info to the user? - Friedrich W. H. Kossebau On Aug. 13, 2013, 8:17 a.m., Boudewijn Rempt wrote: --- This is an automatically generated e-mail

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread Friedrich W. H. Kossebau
On Aug. 11, 2013, 4 a.m., Friedrich W. H. Kossebau wrote: braindump/plugins/quickstates/BraindumpQuickStatesPlugin.cpp, line 38 http://git.reviewboard.kde.org/r/111990/diff/1/?file=177787#file177787line38 No forward-passing of the parent object to the QObject? I wonder who

Re: Review Request 111954: proper use filter_app products flag to enable/disable whole app filters

2013-08-11 Thread Friedrich W. H. Kossebau
On Aug. 9, 2013, 8:20 a.m., Friedrich W. H. Kossebau wrote: Hi Sebastian, In the design of these product definition macros currently all the rules are whitelisting rules, not blacklisting rules. The FILTER_appname products are kind of meta-products (or rather productsets) which

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-10 Thread Friedrich W. H. Kossebau
/#comment27717 karbon/karbonplugins - karbon/plugins or karbon/viewplugins? karbon/karbonplugins seems redundant karbon/plugins/refinepath/RefinePathPlugin.cpp http://git.reviewboard.kde.org/r/111990/#comment27718 Memory management? - Friedrich W. H. Kossebau On Aug. 10, 2013, 1:36

Re: Review Request 111954: proper use filter_app products flag to enable/disable whole app filters

2013-08-09 Thread Friedrich W. H. Kossebau
one-by-one in the disable-because-broken area (yes, porting with mass-breaking states was not considered, bah :) ). But the proposed patch would not match the current logic, so I have to reject it. Will see to solve this in the system design ASAP. - Friedrich W. H. Kossebau On Aug. 8, 2013, 8

Re: [calligra] /: Add api for writing ODF that is generated from the ODF RNG file.

2013-08-04 Thread Friedrich W. H. Kossebau
Hi, really cool work from Jos, happy to see it having made it into Calligra master :) Am Sonntag, 4. August 2013, 17:41:20 schrieb Jos van den Oever: Example: Instead of writing: == xmlWriter-startElement(text:p); xmlWriter-addAttribute(text:style-name, italic);

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Friedrich W. H. Kossebau
Am Sonntag, 4. August 2013, 18:48:17 schrieb Jos van den Oever: On Aug. 4, 2013, 5:57 p.m., Friedrich W. H. Kossebau wrote: Meh, too late, committed while I was giving it finally also a look. Please still pick up the following comments and do a fix-up commit: Thanks for the thorough

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Friedrich W. H. Kossebau
Hi Boudewijn all, Am Montag, 29. Juli 2013, 12:11:25 schrieb Boudewijn Rempt: I want to propose that we start porting Calligra to Qt 5.1 now that 2.7 is released. Jolla is funding KO GmbH to work on porting the core, so this is a good moment to get started. On the other hand, we're in the

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Friedrich W. H. Kossebau
* I value interoperation of Qt5/KF5-based apps over supporting people on questionable platforms Below in-text more detailed: Am Montag, 29. Juli 2013, 21:22:17 schrieb Boudewijn Rempt: On Monday 29 July 2013 Jul 19:07:45 Friedrich W. H. Kossebau wrote: But: having this influence how

Re: Review Request 111751: Refresh TaskStatusItemModel when a Node changes

2013-07-28 Thread Friedrich W. H. Kossebau
it. Got what I mean? - Friedrich W. H. Kossebau On July 27, 2013, 8:58 p.m., Alvaro Soliverez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111751

Re: Review Request 111657: Project performance chart refresh

2013-07-25 Thread Friedrich W. H. Kossebau
: and REVIEW: keywords in the commit message? If not see https://community.kde.org/Sysadmin/GitKdeOrgManual#Commit_hook_keywords Can you also backport to 2.7? - Friedrich W. H. Kossebau On July 24, 2013, 11:40 p.m., Alvaro Soliverez wrote

Review Request 111703: Link calligrakdgantt only against Qt libs, not KDE4_KDECORE_LIBS

2013-07-25 Thread Friedrich W. H. Kossebau
--- Is there a reason to link calligrakdgantt against KDE4_KDECORE_LIBS? For me everythings links fine with just Qt libs as deps. Diffs - 3rdparty/kdgantt/CMakeLists.txt 70bccb5 Diff: http://git.reviewboard.kde.org/r/111703/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 111657: Project performance chart refresh

2013-07-24 Thread Friedrich W. H. Kossebau
that this is the right optimization, do it. - Friedrich W. H. Kossebau On July 23, 2013, 1 p.m., Alvaro Soliverez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111657

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
load a document with multiple sheets and see that the actions are not there. Please add a TODO or add to some proper place (view creation?). - Friedrich W. H. Kossebau On July 22, 2013, 7:10 a.m., Boudewijn Rempt wrote

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
On July 18, 2013, 2:55 p.m., Friedrich W. H. Kossebau wrote: libs/main/KoMainWindow.cpp, lines 202-203 http://git.reviewboard.kde.org/r/111545/diff/1/?file=171113#file171113line202 What is the difference between activePart and m_activePart? And shouldn't members

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
when one file has been created/loaded already does not start a new mainwindow with it. It seems loaded/imported, but is not shown. - Friedrich W. H. Kossebau On July 22, 2013, 7:10 a.m., Boudewijn Rempt wrote: --- This is an automatically

Review Request 111667: Make libcalligrachartshape a static lib, rename to libchartshapecore and no longer install it

2013-07-23 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/111667/diff/ Testing --- Charts still work fine in Sheets (including special controls) and elsewhere. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
On July 21, 2013, 9:59 p.m., Friedrich W. H. Kossebau wrote: For easy testing I recommend checking out the krita-mvc-rempt branch Does not build for me: [ 68%] Building CXX object krita/app/CMakeFiles/krita.dir/krita_automoc.cpp.o In file included from /home/koder/Kode

Re: Review Request 111545: Port komain away from KParts

2013-07-21 Thread Friedrich W. H. Kossebau
/krita_automoc.cpp.o] Fehler 1 make[1]: *** [krita/app/CMakeFiles/krita.dir/all] Fehler 2 make: *** [all] Fehler 2 - Friedrich W. H. Kossebau On July 17, 2013, 11:41 a.m., Boudewijn Rempt wrote: --- This is an automatically generated e-mail

Review Request 111595: Turn some sequences of x += ... statements (with x a QString) into a long chain of additions (for QStringBuilder)

2013-07-19 Thread Friedrich W. H. Kossebau
sheets/dialogs/FormulaDialog.cpp 905b844 sheets/dialogs/ListDialog.cpp ba032b6 Diff: http://git.reviewboard.kde.org/r/111595/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 111413: Plan - Set First Day of Week to Monday if using ISO Week for week numbering

2013-07-19 Thread Friedrich W. H. Kossebau
On July 18, 2013, 10:21 p.m., Alvaro Soliverez wrote: Any update on this? I'd like to see it included in the next beta if possible Sorry, did not yet manage to schedule time for this (due to Akademy etc.). Still want to give this some more investigations to countercheck and understand what

Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
/scripting/Project.cpp b9d9ce0 plugins/dockers/shapecollection/ShapeCollectionDocker.cpp d08ee37 plugins/musicshape/core/tests/MusicXmlWriterTest.cpp ca9a005 words/part/KWDocument.cpp 57aba26 Diff: http://git.reviewboard.kde.org/r/111560/diff/ Testing --- Thanks, Friedrich W. H

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/#review36103 --- On July 18, 2013, 10:25 a.m., Friedrich W. H. Kossebau wrote

Re: Review Request 111545: Port komain away from KParts

2013-07-18 Thread Friedrich W. H. Kossebau
the file deletions in krita are better done in a separate patch: krita/sdk/createplugin.rb:deleted krita/sdk/createtest.py:deleted krita/sdk/pop_extract.rb:deleted ... - Friedrich W. H. Kossebau On July 17, 2013, 11:41 a.m., Boudewijn Rempt wrote

Re: Review Request 111560: Use QStringBuilder

2013-07-18 Thread Friedrich W. H. Kossebau
a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111560/ --- (Updated July 18, 2013, 10:25 a.m

Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module

2013-07-05 Thread Friedrich W. H. Kossebau
/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra BoF at Akademy?

2013-07-05 Thread Friedrich W. H. Kossebau
Hi Shantanu, Am Sonntag, 30. Juni 2013, 12:21:28 schrieb Shantanu Tushar Jha: Hey everyone, We don't have a Calligra BoF scheduled at Akademy yet. Is everyone ok with doing it on Tuesday? I'll go and fill the wiki then. I would be fine with Tuesday if between 14-16 h, given what else is

Re: Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-07-01 Thread Friedrich W. H. Kossebau
/#review35334 --- On June 30, 2013, 9:38 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326

Re: Review Request 111305: ko-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Friedrich W. H. Kossebau
, 2013, 12:40 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/ --- (Updated June 29, 2013

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-30 Thread Friedrich W. H. Kossebau
) - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111306/#review35296 --- On June 29, 2013, 2:31 a.m., Friedrich W. H

Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Friedrich W. H. Kossebau
/r/111326/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 111328: Install all krita headers in ${INCLUDE_INSTALL_DIR}/krita

2013-06-30 Thread Friedrich W. H. Kossebau
--- ... and thus follow the pattern of Words, Sheets, Stage? Diffs - krita/image/CMakeLists.txt 0db29af krita/image/tiles3/CMakeLists.txt 1222d5a krita/ui/CMakeLists.txt 78a61c6 Diff: http://git.reviewboard.kde.org/r/111328/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-30 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/111306/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-30 Thread Friedrich W. H. Kossebau
, 2013, 10:37 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111043/ --- (Updated June 27, 2013

Review Request 111305: ko-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-28 Thread Friedrich W. H. Kossebau
, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111264: fix unwanted changing of m_name in DocxXmlStylesReader::read_style()

2013-06-28 Thread Friedrich W. H. Kossebau
, visit: http://git.reviewboard.kde.org/r/111264/#review35240 --- On June 26, 2013, 9:22 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 111264: fix unwanted changing of m_name in DocxXmlStylesReader::read_style()

2013-06-28 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/111264/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-28 Thread Friedrich W. H. Kossebau
/CMakeLists.txt e0f4a02 stage/part/CMakeLists.txt 6eaf356 words/part/CMakeLists.txt 437f443 Diff: http://git.reviewboard.kde.org/r/111306/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org

Review Request 111286: Remove useless textvariableplugin.desktop

2013-06-27 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/111286/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-27 Thread Friedrich W. H. Kossebau
/sidewinder/excel.h 5b0076c filters/sheets/excel/sidewinder/excel.cpp 50f54c0 filters/sheets/excel/sidewinder/worksheetsubstreamhandler.cpp bd66048 Diff: http://git.reviewboard.kde.org/r/111043/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-27 Thread Friedrich W. H. Kossebau
--- On June 27, 2013, 10:37 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111043/ --- (Updated

Re: Review Request 110596: Slightly improve KoResourceItemChooser UI strings (and add some context markers)

2013-06-27 Thread Friedrich W. H. Kossebau
. Diffs (updated) - libs/widgets/KoResourceItemChooser.cpp dc0838b Diff: http://git.reviewboard.kde.org/r/110596/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Re: Review Request 110596: Slightly improve KoResourceItemChooser UI strings (and add some context markers)

2013-06-27 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110596/#review32973 --- On May 22, 2013, 3:23 p.m., Friedrich W. H. Kossebau wrote

Review Request 111264: fix unwanted changing of m_name in DocxXmlStylesReader::read_style()

2013-06-26 Thread Friedrich W. H. Kossebau
not. Matus, Inge, you are more the experts here, so please give it a check :) Okay to backport to 2.7 2.6 ? Diffs - filters/words/docx/import/DocxXmlStylesReader.cpp 8b38716 Diff: http://git.reviewboard.kde.org/r/111264/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Review Request 111265: Rename all namespaceless plugin modules to {calligra, braindump}-{shape, tool, docker, ...}-xxx

2013-06-26 Thread Friedrich W. H. Kossebau
sheets/shape/CMakeLists.txt 9fc7d3c sheets/shape/spreadsheetshape-deferred.desktop 11479bf sheets/shape/spreadsheetshape.desktop d578345 Diff: http://git.reviewboard.kde.org/r/111265/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Please test the MPP/MPX import feature of Calligra Plan in master

2013-06-25 Thread Friedrich W. H. Kossebau
Hi Andrius, thanks for trying and reporting, very welcome! Am Dienstag, 25. Juni 2013, 16:42:43 schrieb Andrius da Costa Ribas: Friedrich, I've tried it with both mpxj-4.3.0 and mpxj-4.4.0 but it didn't work because PlanWriter java class invokes non existing methods of mpxj. Ah, too bad.

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-25 Thread Friedrich W. H. Kossebau
to give all changes at least another quick pair of eyes before :) - Friedrich W. H. Kossebau On June 18, 2013, 10:32 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Plan, Karbon: Disable the Maintainer wanted splashscreen for release branches?

2013-06-25 Thread Friedrich W. H. Kossebau
Am Dienstag, 18. Juni 2013, 09:25:21 schrieb C. Boemann: On Tuesday 18 June 2013 01:41:50 Elvis Stansvik wrote: 2013/6/18 Friedrich W. H. Kossebau kosse...@kde.org Hi, I wonder if it is a go idea to have the Maintainer wanted splashscreen in Plan and Karbon also enabled

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-18 Thread Friedrich W. H. Kossebau
/words_wps_import.desktop 27b4021 Diff: http://git.reviewboard.kde.org/r/111031/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Plan, Karbon: Disable the Maintainer wanted splashscreen for release branches?

2013-06-17 Thread Friedrich W. H. Kossebau
Hi, I wonder if it is a go idea to have the Maintainer wanted splashscreen in Plan and Karbon also enabled in the 2.7 releases. People who still see some use in either programs surely will get annoyed quickly, and there is no option to turn it off. So I would argue to enable that splashscreen

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-16 Thread Friedrich W. H. Kossebau
--- On June 14, 2013, 11:08 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111031/ --- (Updated

Review Request 111040: Fix possibly memory leak by not called destructor on incomplete type in kis_mask.cc

2013-06-15 Thread Friedrich W. H. Kossebau
/111040/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-15 Thread Friedrich W. H. Kossebau
. - Friedrich W. H. Kossebau On June 12, 2013, 8:01 p.m., Sascha Suelzer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110910

Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-14 Thread Friedrich W. H. Kossebau
/import/words_wps_import.desktop 27b4021 Diff: http://git.reviewboard.kde.org/r/111031/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110965: fix broken conversion of results from koscript code evaluation in KRScriptHandler::evaluate()

2013-06-14 Thread Friedrich W. H. Kossebau
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110965/#review34247 --- On June 11, 2013, 11:25 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-14 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/111031/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110965: fix broken conversion of results from koscript code evaluation in KRScriptHandler::evaluate()

2013-06-14 Thread Friedrich W. H. Kossebau
QStrings if those are the result of the evaluation? Diffs - kexi/plugins/reports/krscriptfunctions.cpp b25b92d libs/koreport/renderer/scripting/krscripthandler.cpp 833f4f3 Diff: http://git.reviewboard.kde.org/r/110965/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Friedrich W. H. Kossebau
. - Friedrich W. H. Kossebau On June 9, 2013, 10:35 a.m., Sascha Suelzer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110910

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Friedrich W. H. Kossebau
On June 11, 2013, 4:44 p.m., Friedrich W. H. Kossebau wrote: libs/widgets/KoResourceItemChooserContextMenu.h, lines 72-75 http://git.reviewboard.kde.org/r/110910/diff/1/?file=149238#file149238line72 Why not setX here? Would be the usual pattern in Qt/KDE/Calligra. So e.g

Review Request 110965: fix broken conversion of results from koscript code evaluation in KRScriptHandler::evaluate()

2013-06-11 Thread Friedrich W. H. Kossebau
/reports/krscriptfunctions.cpp b25b92d libs/koreport/renderer/scripting/krscripthandler.cpp 833f4f3 Diff: http://git.reviewboard.kde.org/r/110965/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel

Please test the MPP/MPX import feature of Calligra Plan in master

2013-06-06 Thread Friedrich W. H. Kossebau
Hi, the last weeks I looked into how to make Calligra Plan's existing import filter for MS Project (*.mpp) and MS Project Exchange (*.mpx) files working, without needing the user to fuss around with installing and setting up more stuff. I managed things to work for me, and now would like to

Re: Callgira 2.7 Beta 2

2013-06-01 Thread Friedrich W. H. Kossebau
Hi Cyrille, Am Sonntag, 19. Mai 2013, 17:52:41 schrieb Cyrille Berger Skott: Hi, Calligra 2.7 Beta 2 packages have been uploaded to ftpmaster and will be announced on wednesday/thursday. b3002335a9fa7e6b41eba5dde8933372 calligra-2.6.91.tar.bz2 okias on #calligra proposed to use xz

Re: Review Request 110719: fix KoXmlReader to break on error instead of trying on and on

2013-05-30 Thread Friedrich W. H. Kossebau
--- On May 29, 2013, 11:54 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110719

Review Request 110719: fix KoXmlReader to break on error instead of trying on and on

2013-05-29 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/110719/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Calligra Active 2.7 beta repo for Plasma Active on merproject.org available

2013-05-28 Thread Friedrich W. H. Kossebau
Hi Activists, as you might know I am trying to do proper packaging of Calligra Active for Plasma Active on the OBS of the wonderful Mer project, so everyone can easily try what there currently is in Calligra Active (no time to get into development here myself, just providing packaging service,

Re: Review Request 110664: Create metaplugins containing smaller plugins

2013-05-27 Thread Friedrich W. H. Kossebau
would need if (METAPLUGINS) for the plugin creation. Still somehow feels cleaner to me. - Friedrich W. H. Kossebau On May 27, 2013, 10:20 a.m., Boudewijn Rempt wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 109046: Normalize SIGNAL and SLOT signatures in the top level directory of Plan

2013-05-27 Thread Friedrich W. H. Kossebau
:) - Friedrich W. H. Kossebau On May 27, 2013, 4:58 p.m., Inge Wallin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109046

Re: Review Request 109046: Normalize SIGNAL and SLOT signatures in the top level directory of Plan

2013-05-26 Thread Friedrich W. H. Kossebau
with pointers and update this patch? - Friedrich W. H. Kossebau On Feb. 26, 2013, 5:22 p.m., Inge Wallin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109046

Review Request 110594: Remove unused image_popup menu declaration in krita.rc

2013-05-22 Thread Friedrich W. H. Kossebau
--- Seems no longer used Diffs - krita/krita.rc 461b994 Diff: http://git.reviewboard.kde.org/r/110594/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Review Request 110595: Remove get-prefix from getResourceByName/getAssignedTagsList/getTagNamesList method names

2013-05-22 Thread Friedrich W. H. Kossebau
/plugins/extensions/bigbrother/bigbrother.cc f59e55e Diff: http://git.reviewboard.kde.org/r/110595/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 110596: Slightly improve KoResourceItemChooser UI strings (and add some context markers)

2013-05-22 Thread Friedrich W. H. Kossebau
/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110600: Turn filemanager templates into product + move from /templates to /extra/filemanagertemplates

2013-05-22 Thread Friedrich W. H. Kossebau
03a8595 templates/insert_ident_string.sh d73b7ea Diff: http://git.reviewboard.kde.org/r/110600/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 110579: Fix compilation on ARM: result of dividing by 2.0 is double, so not qreal (qMax needs same types)

2013-05-21 Thread Friedrich W. H. Kossebau
/elements/MultiscriptElement.cpp 9cdcc56 Diff: http://git.reviewboard.kde.org/r/110579/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110581: Rename installed libkdchart to libcalligrakdchart, to prevent naming clashes

2013-05-21 Thread Friedrich W. H. Kossebau
f168557 plan/libs/ui/CMakeLists.txt f813a10 plugins/chartshape/CMakeLists.txt c853ec0 plugins/reporting/chart/CMakeLists.txt 92bf3de Diff: http://git.reviewboard.kde.org/r/110581/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 110581: Rename installed libkdchart to libcalligrakdchart, to prevent naming clashes

2013-05-21 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110581/#review32915 --- On May 21, 2013, 6:31 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request 109214: Kexi asks for passwords without modal dialogs; improved messages and assistants

2013-05-05 Thread Friedrich W. H. Kossebau
Am Samstag, 4. Mai 2013, 23:44:47 schrieb Jaroslaw Staniek: Hi, After 2 months of waiting because it's high time for 2.7, I committed this breaking the review rule. But I don't know what's the reason that nobody reviewed. Is the change too large or complicated? Or what to do to get general

Re: Adding another lib into the productset system

2013-04-30 Thread Friedrich W. H. Kossebau
Am Mittwoch, 1. Mai 2013, 00:03:24 schrieb Jaroslaw Staniek: Hello Freidrich, By the way I have one question, in /CMakeLists.txt there's line calligra_define_product(KEXI Full Kexi (for Desktop) NEEDS KEXI_APP WANTS PLUGIN_KEXI_SPREADSHEETMIGRATION) I'd like to disable the optional

Adding another lib into the productset system

2013-04-29 Thread Friedrich W. H. Kossebau
Hi Luke, I saw on irc that you want to add another library and where wondering how to integrate with the productset system. For a first idea please read cmake/productsets/README Then this would be the rough guideline what to do: 1. You define your product

Re: Review Request 110080: Fix tooltips of the page navigator of Kexi's report view

2013-04-19 Thread Friedrich W. H. Kossebau
/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110079: Move the export buttons from the Kexi report design toolbar into a submenu of the view main menu

2013-04-18 Thread Friedrich W. H. Kossebau
/diff/ Testing --- Invoking the entries of the submenu works as expected. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110080: Fix tooltips of the page navigator of Kexi's report view

2013-04-18 Thread Friedrich W. H. Kossebau
:) Diffs - kexi/widget/utils/kexirecordnavigator.cpp b1e2384 kexi/widget/utils/kexirecordnavigator.h b73fe4f kexi/plugins/reports/kexireportview.cpp c215e8a Diff: http://git.reviewboard.kde.org/r/110080/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 109046: Normalize SIGNAL and SLOT signatures in the top level directory of Plan

2013-04-15 Thread Friedrich W. H. Kossebau
On March 30, 2013, 2:31 p.m., Friedrich W. H. Kossebau wrote: As intermediate maintainer I am interested to see this patch go in, but please first fix the wrong removal of the constness from pointer type args and upload again for a final review :) - Friedrich W. H

Proposing myself as intermediate(sic!) maintainer of Plan

2013-04-13 Thread Friedrich W. H. Kossebau
Hi, Dag nicely sent me off-list some info to use in my upcoming blog post about the search of a new maintainer for Calligra Plan. I plan ;) to post the blog on monday (still need to write it). While playing around with Plan to learn more about it for the blog post I saw a few small things

Review Request 109898: miniimprovement for Curve Brush Options UI

2013-04-08 Thread Friedrich W. H. Kossebau
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/curveoptionsform_after.png Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 109896: Lot's of margin twisting in Krita brush config UI

2013-04-08 Thread Friedrich W. H. Kossebau
--- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 109897: Remove any hardcoding of spacing to 6 px and margins to 9/11 px in Krita's UI

2013-04-08 Thread Friedrich W. H. Kossebau
/forms/wdgselectionoptions.ui 19fc539 krita/ui/forms/wdgshapeoptions.ui 65c0e9c krita/ui/forms/wdgtabletsettings.ui dd0cde5 Diff: http://git.reviewboard.kde.org/r/109897/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra

Review Request 109899: miniimprovement for Hatching Brush Options UI

2013-04-08 Thread Friedrich W. H. Kossebau
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/hatchingoptionsform_before.png http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/hatchingoptionsform_after.png Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing

Review Request 109901: miniimprovement for Hatching Brush Preferences UI

2013-04-08 Thread Friedrich W. H. Kossebau
/uploaded/files/2013/04/07/hatchingpreferencesform_before.png http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/hatchingpreferencesform_after.png Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org

Review Request 109902: miniimprovement for Sketch Brush Size UI *

2013-04-08 Thread Friedrich W. H. Kossebau
/sketchsizeform_before.png http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/sketchsizeform_after.png Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109897: Remove any hardcoding of spacing to 6 px and margins to 9/11 px in Krita's UI

2013-04-08 Thread Friedrich W. H. Kossebau
Sven, Boud, all, Am Sonntag, 7. April 2013, 20:32:09 schrieb Friedrich W. H. Kossebau: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109897

Review Request 109889: Postfix all texts of labels before edit fields with a : in Krita's brush config UI

2013-04-06 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/109889/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Calligra spring 2013 sprint report for the Dot needed!

2013-03-25 Thread Friedrich W. H. Kossebau
Hi, while we have had some nice blog posts about the Calligra sprint from e.g. Sujith, Lukas, Sven and Jarosław... http://sujithh.info/2013/03/calligra-sprint-2013-day-1-bangalore/ http://frinring.wordpress.com/2013/03/08/calligra-spring-2013-sprint-started/

Re: Wiki build instructions updated for product sets

2013-03-24 Thread Friedrich W. H. Kossebau
Hi Elvis, Am Sonntag, 24. März 2013, 11:13:54 schrieb Elvis Stansvik: Hi all, I took the liberty of updating http://community.kde.org/Calligra/Building#Building_selected_applications to include info about product sets. Would be nice if someone (Friedrich?) could take a short look to

Re: Review Request 109615: turn all filters in filters/ into individual products, make core calligralibs also a product

2013-03-23 Thread Friedrich W. H. Kossebau
for all default productsets for me. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Braindump - officially declaring it as unmaintained?

2013-03-22 Thread Friedrich W. H. Kossebau
Hi Cyrille, Am Freitag, 22. März 2013, 14:46:18 schrieb Cyrille Berger: Hi, On 2013-03-21 22:51, Friedrich W. H. Kossebau wrote: Hi Cyrille, at the Calligra Sprint two weeks ago Braindump was found to be actually unmaintained, at least the last commit to braindump from you seems

<    1   2   3   4   5   6   7   8   9   10   >