This revision was automatically updated to reflect the committed changes.
Closed by commit R8:1bbb6e00022b: Port Calligra Gemini for 3.x (authored by
leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8310?vs=20790=22079#toc
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
staniek accepted this revision.
staniek added a comment.
This revision is now accepted and ready to land.
+1 from me, appeciated the port!
- have not run it
- have not reviewed the QML part
INLINE COMMENTS
> CMakeLists.txt:3
>
> +add_definitions("-DUNICODE -D_UNICODE")
> +
danders added a comment.
Dan Leinir Turthra Jensen skrev den 2017-10-30 12:06:
I hope ppl have just taken an extended summer vacation ;)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D8310
To: leinir, Calligra-Devel-list
Cc: danders, vandenoever
leinir added a comment.
Pinged on IRC on Friday and i'll just archive the chat here:
[27/10/2017 12:06:02] <leinir> if possible, i'd really like a review
on this one... https://phabricator.kde.org/D8310
[27/10/2017 13:24:23] <boud> leinir: I am afraid that you really have
danders added a comment.
I'm clueless on qtquick, but unless somebody else has comments I'd say ship
it.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D8310
To: leinir, Calligra-Devel-list
Cc: danders, vandenoever
leinir created this revision.
leinir added a reviewer: Calligra-Devel-list.
leinir added a project: Calligra: 3.0.
REVISION SUMMARY
This patch reenables the Calligra Gemini product for compilation, as it has
now been ported, including a variety of other work required for Calligra Gemini
to
