Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104607/ --- Review request for Calligra. Description --- Diffs -

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104607/#review12479 --- Not bad. Would you mind telling where you experience the

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104607/ --- (Updated April 15, 2012, 5:11 p.m.) Review request for Calligra.

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread Friedrich W. H. Kossebau
On April 15, 2012, 5:06 p.m., C. Boemann wrote: Not bad. Would you mind telling where you experience the problem today? context menu of the horizontal ruler, well, at least the one in Calligra Words, seems not all programs have this. - Friedrich W. H.

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
On April 15, 2012, 5:06 p.m., C. Boemann wrote: libs/main/KoView.cpp, line 565 http://git.reviewboard.kde.org/r/104607/diff/1/?file=56699#file56699line565 i think this todo should be fixed before pushing Friedrich W. H. Kossebau wrote: I like the grouping of the similar unit