Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-23 Thread Friedrich W. H. Kossebau
On April 21, 2012, 10:20 a.m., C. Boemann wrote: Me and Cyrille have pushed a build fix each with that it's read - great work ! btw we even got a bug for this behaviour in the mean time Ah, good, thanks for fixing, Cyrille and Boemann! So following

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-23 Thread C. Boemann
On Monday 23 April 2012 15:41:35 Friedrich W. H. Kossebau wrote: So following http://community.kde.org/Calligra/Policies/Commits I will now squash the branch into a single commit and commit that one to master, right? right :) ___ calligra-devel

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-23 Thread Friedrich W. H. Kossebau
On April 21, 2012, 10:27 a.m., C. Boemann wrote: this was the bug you branch will (also) fix: https://bugs.kde.org/show_bug.cgi?id=298510 Hm, sure that bug is fixed by this branch? While for new documents I can confirm that the unit setting is the one of the last instance of

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104626/#review12827 --- This review has been submitted with commit

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104626/#review12749 --- Ship it! Me and Cyrille have pushed a build fix each with

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104626/#review12750 --- this was the bug you branch will (also) fix:

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-17 Thread Friedrich W. H. Kossebau
On April 17, 2012, 4:17 a.m., C. Boemann wrote: libs/odf/KoUnit.h, line 80 http://git.reviewboard.kde.org/r/104626/diff/1/?file=56935#file56935line80 Maybe make this into QFlags, if we want as you Say to have imperial vs metric too; btw for the ui list it may be an idea to

Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-16 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104626/ --- Review request for Calligra and C. Boemann. Description --- Sigh...

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104626/#review12550 --- I like it very much, and I found only a few issues. Before we