dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
BRANCH
arcpatch-D25664
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones,
dfaure accepted this revision as: dfaure.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste,
ognarb, cochise, vandenoever
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e29dc97256de: [WIP]: Port away from deprecated
QSignalMapper (authored by ognarb).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25664?vs=70790=70818
REVISION
ognarb edited the summary of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25714
To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
ognarb added a task: T11542: Remove KHTML.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25714
To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
ognarb added a reviewer: Calligra: 3.0.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25714
To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.
TEST PLAN
Compile, but I need to figure out why before and after this change the filter
doesn't work.
REPOSITORY
R8 Calligra
BRANCH
dcaliste added a comment.
Just a suggestion to avoid adding a variable which meaning may be redundant
with the state of an already existing one. Otherwise LGTM.
INLINE COMMENTS
> ColorTableDestination.cpp:26
> ColorTableDestination::ColorTableDestination( Reader *reader,
>
pvuorela created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
pvuorela requested review of this revision.
REVISION SUMMARY
RTF spec says a color entry without anything defined is a "default
color", but doesn't specify more what that is.
pvuorela added inline comments.
INLINE COMMENTS
> dcaliste wrote in ColorTableDestination.h:45
> I'm wondering, if we could use the invalid status of QColor as this flag ?
>
> See later…
Should work, but I'm not sure would it be much better. Saves one boolean
instance during loading a file,
On dinsdag 3 december 2019 15:54:53 CET Carl Schwan wrote:
> Hello,
>
> I wanted to know if we could change the Qt dependency from Qt 5.3 to Qt 5.9
> at least.
>
> I think some parts already depends on Qt 5.7 at least. For example in
> Calligra Gemini, there is
> a dependency to Kirigami, that
pvuorela added reviewers: davidllewellynjones, dcaliste.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25715
To: pvuorela, davidllewellynjones, dcaliste
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
Hello,
I wanted to know if we could change the Qt dependency from Qt 5.3 to Qt 5.9 at
least.
I think some parts already depends on Qt 5.7 at least. For example in Calligra
Gemini, there is
a dependency to Kirigami, that depends on Qt Quick Control 2 introduced in Qt
5.7.
I suppose there are
dcaliste added a comment.
@pvuorela as you prefer, anyway, it's a question of taste, I find it myself
easier to follow if the information is on one variable only. But your solution
is good also, the file is small and is kept small so easy to follow.
REPOSITORY
R8 Calligra
REVISION DETAIL
14 matches
Mail list logo
