D15412: [filters] Extend table lifetime

2018-09-17 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:cb7ff65d2e7c: Extend table lifetime (authored by 
anthonyfieroni).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15412?vs=41552=41841

REVISION DETAIL
  https://phabricator.kde.org/D15412

AFFECTED FILES
  filters/libmsooxml/MsooXmlDrawingReaderTableImpl.h
  filters/libmsooxml/MsooXmlDrawingReaderTableMethods.h
  filters/libmsooxml/PresetDrawingMLTables.h
  filters/libodf2/KoTable.cpp
  filters/libodf2/KoTable.h
  filters/stage/pptx/PptxXmlSlideReader.h
  filters/words/docx/import/DocxXmlDocumentReader.cpp
  filters/words/docx/import/DocxXmlDocumentReader.h

To: anthonyfieroni, danders, boemann, #calligra:_3.0, staniek
Cc: staniek, Calligra-Devel-list, dcaliste, cochise, vandenoever


D15403: {Style] Default sheets to white background

2018-09-17 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e5fc394f4a54: [Style] Default sheets to white background 
(authored by anthonyfieroni).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15403?vs=41338=41840

REVISION DETAIL
  https://phabricator.kde.org/D15403

AFFECTED FILES
  sheets/Style.cpp

To: anthonyfieroni, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


D12839: Get Calligra to compile with Qt 5.11

2018-09-17 Thread Anthony Fieroni
anthonyfieroni closed this revision.
anthonyfieroni added a comment.


  It was merged.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D12839

To: nerdopolist, Calligra-Devel-list, #calligra:_3.0, staniek
Cc: anthonyfieroni, #calligra:_3.0, dcaliste, cochise, vandenoever


D15549: Words: Save anchor info also for page-anchored shapes

2018-09-17 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:02f34b05723a: Words: Save anchor info also for 
page-anchored shapes (authored by danders).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15549?vs=41737=41811#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15549?vs=41737=41811

REVISION DETAIL
  https://phabricator.kde.org/D15549

AFFECTED FILES
  words/part/KWOdfWriter.cpp

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-09-17 Thread Anthony Fieroni
anthonyfieroni added a comment.


  Any other ideas for special handling of headerRows == 0?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


D15549: Words: Save anchor info also for page-anchored shapes

2018-09-17 Thread Camilla Boemann
boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  danders_words_anchor

REVISION DETAIL
  https://phabricator.kde.org/D15549

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


D15567: Words: Do not popup contextmenu twice

2018-09-17 Thread Dan Leinir Turthra Jensen
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Yes please, thank you! That has frankly been bugging me for a while... We're 
sure there's no side effects here? But, yeah, having two menus pop up 
underneath each other is sort of annoying ;)

REPOSITORY
  R8 Calligra

BRANCH
  danders_words_contextmenu

REVISION DETAIL
  https://phabricator.kde.org/D15567

To: danders, boemann, leinir
Cc: leinir, Calligra-Devel-list, dcaliste, cochise, vandenoever


D15567: Words: Do not popup contextmenu twice

2018-09-17 Thread Dag Andersen
danders created this revision.
danders added a reviewer: boemann.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Popup menu was called from mousePressEvent.
  No need as it is handled in contextMenuEvent.

REPOSITORY
  R8 Calligra

BRANCH
  danders_words_contextmenu

REVISION DETAIL
  https://phabricator.kde.org/D15567

AFFECTED FILES
  words/part/KWCanvas.cpp

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


D15549: Words: Save anchor info also for page-anchored shapes

2018-09-17 Thread Dag Andersen
danders added a comment.


  After reading the fine print, see: 
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1420028_253892949
  it seems to me a shape can be anchored to a page in different ways. Note this:
  "If the attribute value is not from-left and not from-inside, the svg:x 
attribute associated with the frame element is ignored for text documents."
  This would explain that LO seems to discard x,y when anchor info is not saved.
  Afaics there is no defined default values for anchor values.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15549

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever