D18466: Fixed calligra crashing when opening remote document
niccolove added a comment. I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks like a different problem (calligrasheets manages printing?). About removing features from slotLoadCompleted, it is important to notice that it is only called by openDocumentInternal itself, so that should not be a problem. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
boemann added a comment. Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it. Also please check in all of our applications as some might reimplement virtual methods REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove added a comment. I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
boemann added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove updated this revision to Diff 50100. niccolove added a comment. - Moving the if from slotLoadCompleted to openDocumentInternal. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50098=50100 BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 AFFECTED FILES libs/main/KoMainWindow.cpp To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
boemann added a comment. Yes that description helped a lot, and you are doing great. Keep up the good work :) One concern though - how often and when is openDoumentInternal called. I'm a bit afraid that we just add some functionality to a place that might be used for something else REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove added a comment. At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replace the root document instead of opening a new window. It makes more sense, now that I think of it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove added a comment. Sure. Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but not in openDocumentInternal. I therefore added that function and it now works. But, when slotLoadCompleted is called (that is, after slotFilePrint), there's a check to open a new window if there's already a non-blank document. Since the root document was already set, it opened a new window with the same document. I therefore added the conditions of the two documents being different. I hope I've been clear, this is one of my first commits here :-/ REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
boemann added a comment. Could you please describe what you have done and why REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove updated this revision to Diff 50098. niccolove added a comment. - Fixed typos REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50097=50098 BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 AFFECTED FILES libs/main/KoMainWindow.cpp To: niccolove Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D18466: Fixed calligra crashing when opening remote document
niccolove created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. niccolove requested review of this revision. REVISION SUMMARY BUG:358581 REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 AFFECTED FILES libs/main/KoMainWindow.cpp To: niccolove Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
