D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read 
and write (authored by danders).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11971?vs=31423=54770#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11971?vs=31423=54770

REVISION DETAIL
  https://phabricator.kde.org/D11971

AFFECTED FILES
  libs/main/tests/documentstructuretest.cpp
  libs/odf/KoDocumentInfo.cpp
  libs/odf/KoDocumentInfo.h

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever


D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
danders added a comment.


  Yes, looks sane, I'll deal with it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D11971

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever


D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-25 Thread Dag Andersen
danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  I think this should be ok

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela, danders
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandenoever


D19973: MsooXmlCommonRead: protect member for double free

2019-03-25 Thread Dag Andersen
danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19973

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever