D29242: WIP: redesign sidebar

[Anthony Fieroni]

anthonyfieroni added a comment.


  > The idea is to remove some of the configuration possibility: for example 
only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at 
the top and bottom was completely broken anyway so I don't think many people 
did it).
  
  I think it can be repaired, it's broken, i agree.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  In D29242#658883 , @boemann wrote:
  
  > Well you are definitely in the right class to make such changes.
  >
  > The thing is the current  code was made to adopt to many different user 
wishes - so the user could choose
  >
  > What you are doing is to throw all that away - would it be impossible to 
have this new way as a mode so we don't throw away the old but enhance it with 
something new.
  >
  > I don't mind if the new mode becomes default
  
  
  The idea is to remove some of the configuration possibility: for example only 
allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top 
and bottom was completely broken anyway so I don't think many people did it).
  
  For the TabBar orientation, I'm trying to create only the the one in the 
first mockup from manueljlin and then add then probably the also the one from 
the last mockup. This is really WIP and I didn't thought it would be send to 
the mailing list :/

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

[Anthony Fieroni]

anthonyfieroni added a comment.


  I don't know everyone wants tools to be above edit window. That's pretty old 
stile when resolution was 4:3 that's why they was arranged one above another. 
But i agree that it should be flexible to be horizontal or vertical as needed.

INLINE COMMENTS

> KoModeBox.cpp:485-494
> +void KoModeBox::slotContextMenuRequested(const QPoint ) {
>  QMenu menu;
> -KSelectAction* textAction = new KSelectAction(i18n("Text"), );
> +KSelectAction *textAction = new KSelectAction(i18n("Text"), );
>  connect(textAction, SIGNAL(triggered(int)), SLOT(switchIconMode(int)));
>  menu.addAction(textAction);
>  textAction->addAction(i18n("Icon and Text"));
>  textAction->addAction(i18n("Icon only"));

Do not made unrelated changes.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

[Camilla Boemann]

boemann added a comment.


  Well you are definitely in the right class to make such changes.
  
  The thing is the current  code was made to adopt to many different user 
wishes - so the user could choose
  
  What you are doing is to throw all that away - would it be impossible to have 
this new way as a mode so we don't throw away the old but enhance it with 
something new.
  
  I don't mind if the new mode becomes default

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D29242: WIP: redesign sidebar

[Carl Schwan]

ognarb added a comment.


  There is a mockup here: T12837  this is 
really WIP I just created the diff because I asked someone to help me with a 
part of the code and I needed to show them the code.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever