[Differential] [Updated] D362: Modularity++: Move find_package() to places where they belong, make other optional
rempt added a comment. I would prefer to have as many checks in the toplevel cmakelists.txt as possible, actually, because we often end up having a check in two places if we don't. I think that this change would be best applied to a kexi-exit branch, where you can prepare for creating the separate repo by doing bigger refactorings. For me, if this would land, I probably would have to restore the checks when preparing krita's exit branch. But then, that's going to need a bigger refactoring of the build system in any case. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list, wicik, staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Commented On] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods
rempt added a comment. Can you also add michael abrahams as a reviewer? REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Updated] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods
rempt added a comment. Um... But we've been building pigment and krita with msvc for years now? REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Accepted] D269: Replace KoToolButton with KoToolAction
rempt accepted this revision. rempt added a comment. This revision is now accepted and ready to land. It seems to work in Krita, I tested with two different main windows and changing the shortcuts, and that was fine. REPOSITORY rCALLIGRA Calligra BRANCH improveToolBoxes REVISION DETAIL https://phabricator.kde.org/D269 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, boemann, abrahams, rempt Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Updated] D113: convert-kicon.pl on calligra/frameworks
rempt added a comment. Erm, what does this patch fix for you? As far as I can see, icons (mostly) already work in the frameworks branch, so I'm not really happy with introducting another big patch that changes a lot of lines just for cleanup reasons. But for 3.0, the goal should be to make things work with minimal changes. Though there is something weird: on my kubuntu kf5 system, I do get icons in Krita's toolbox with a frameworks branch, in my OpenSUSE vm, not. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D113 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt Cc: Calligra-Devel, staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
