Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- (Updated Sept. 5, 2015, 9:58 p.m.) Status -- This change has been discarded. Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/#review84608 --- This has been commited meanwhile as c0453b985be60dd85f9c264f1d17455edd5a9bf1, so please close this review request, to help us manage open ones :) - Friedrich W. H. Kossebau On May 30, 2015, 11:04 p.m., Nerdopolis Turfwalker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- (Updated May 30, 2015, 11:04 p.m.) Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/#review80989 --- libs/flake/KoGridData.h (line 27) https://git.reviewboard.kde.org/r/123955/#comment55470 Why is the QWidget needed here. Can you give the error message you had? Would be a QObject fix the problem too? libs/flake/KoPathPoint.cpp (line 31) https://git.reviewboard.kde.org/r/123955/#comment55471 Please don't comment out code. Just remove it if it no longer works. libs/flake/KoPathShape.cpp (line 54) https://git.reviewboard.kde.org/r/123955/#comment55472 Don't comment out code. Just remove it if it no longer works. - Thorsten Zachmann On May 30, 2015, 11:04 p.m., Nerdopolis Turfwalker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- (Updated May 30, 2015, 11:04 p.m.) Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
