This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e29dc97256de: [WIP]: Port away from deprecated
QSignalMapper (authored by ognarb).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25664?vs=70790&id=70818
REVISION DET
dfaure accepted this revision as: dfaure.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste,
ognarb, cochise, vandenoever
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
BRANCH
arcpatch-D25664
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste
ognarb marked 3 inline comments as done.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste,
ognarb, cochise, vandenoever
ognarb updated this revision to Diff 70790.
ognarb added a comment.
Finish porting away from QSignalMapper
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25664?vs=70755&id=70790
BRANCH
arcpatch-D25664
REVISION DETAIL
https://phabricator.kde.org/D25664
ognarb added a comment.
Ok I will replace the qAsConst with koAsConst ;)
I suppose the reason why Calligra needs Qt5.3 is the Qt Quick 1 support?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, C
dfaure added a comment.
Then write your own, it's easy:
// this adds const to non-const objects (like std::as_const)
template Q_DECL_CONSTEXPR typename std::add_const::type
&koAsConst(T &t) noexcept { return t; }
// prevent rvalue arguments:
template void koAsConst(const T
danders added a comment.
Afaik we still support qt5.3, I don't think qAsConst is availabel.
Disregard if this has changed.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidl
ognarb planned changes to this revision.
ognarb added a comment.
Planned changes: Port all the QSignalMapper ;)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: dfaure, Calligra-Devel-list, davidllewellynjones, dcalist
ognarb updated this revision to Diff 70755.
ognarb marked 7 inline comments as done.
ognarb added a comment.
Thanks for the review David. I will now follow your advice and continue
porting
away from QSignalMapper.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> KoDialog.cpp:161
>
> -QObject::connect(button, SIGNAL(clicked()),
> - &mButtonSignalMapper, SLOT(map()));
> +QObject::connect(but
ognarb retitled this revision from "[WIP]: Port away from QSignalMapper" to
"[WIP]: Port away from deprecated QSignalMapper".
ognarb edited the summary of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6
Cc: Calligra-D
12 matches
Mail list logo
