Re: using reststop with tilt

2010-07-09 Thread David Susco
Arg, I new it would be something simple. Thanks. Dave On Thu, Jul 8, 2010 at 10:54 PM, Philippe Monnet r...@monnet-usa.com wrote: David, If you're using Tilt, to make partials work in ERB or HAML you would need to explicitly call render with the name of the partial. So for example, in ERB:  

Re: Wiki vs homepage

2010-07-09 Thread David Susco
I agree to the separation as well. A site that introduces camping with a simple example/tutorial and that links to a wiki (with more advanced stuff) and the mailing list is a good way to go about it. Dave On Thu, Jul 8, 2010 at 10:20 PM, Philippe Monnet r...@monnet-usa.com wrote: Yeah, I agree

Re: using reststop with tilt

2010-07-09 Thread David Susco
FYI, when not using reststop, calling render :_some_partial from a template will automatically wrap the partial in the layout. I think this is because the render method automatically wraps a view in the layout if the layout exists, rather than checking if the first character is an underscore and

Re: using reststop with tilt

2010-07-09 Thread Philippe Monnet
For issue #1: I think I added the change on line 166( when committing my last changes for gem 0.5.3) to check for partials in the normal flow of restop_render. Could you verify you have the latest? For issue #2: what does your %=render ... % code looks like? Is only the name of the partial

Re: using reststop with tilt

2010-07-09 Thread David Susco
I do have the latest reststop gem, but the problem occurs when I'm *not* using reststop. The regular camping render method does not check for the _, where as the reststop render does. Line 166 is reststop is working, but there's no equivalent logic (that I can see) in camping render. I've tried

Re: using reststop with tilt

2010-07-09 Thread Magnus Holm
Should we apply a patch like this? diff --git a/lib/camping-unabridged.rb b/lib/camping-unabridged.rb index 636ad6f..f3195b3 100644 --- a/lib/camping-unabridged.rb +++ b/lib/camping-unabridged.rb @@ -272,7 +272,7 @@ module Camping def render(v, o={}, b) if t = lookup(v) s =

Re: using reststop with tilt

2010-07-09 Thread Philippe Monnet
Yes I think the first patch makes sense to filter out partials from the process of applying the layout. For the second patch now I get why Dave's parameters were not being used. So now your change would send *a . Cool. Dave do you want to try that out? And then Magnus can go ahead and apply it

Re: using reststop with tilt

2010-07-09 Thread David Susco
Thanks Magnus, those changes make sense to me. I can test them out no problem, just not until Monday. I'll send out another e-mail then. Thanks, Dave On Fri, Jul 9, 2010 at 5:30 PM, Philippe Monnet r...@monnet-usa.com wrote: Yes I think the first patch makes sense to filter out partials from