Re: using reststop with tilt

2010-07-10 Thread David Susco
Got a chance to work on this this morning. First patch worked fine, no problem. The second wasn't working for me until I remembered you need to separate out a method's name as its own argument when passing it to another method. So, from my example above, you need to do this: render :_button,

Re: using reststop with tilt

2010-07-09 Thread David Susco
Arg, I new it would be something simple. Thanks. Dave On Thu, Jul 8, 2010 at 10:54 PM, Philippe Monnet r...@monnet-usa.com wrote: David, If you're using Tilt, to make partials work in ERB or HAML you would need to explicitly call render with the name of the partial. So for example, in ERB:  

Re: using reststop with tilt

2010-07-09 Thread David Susco
FYI, when not using reststop, calling render :_some_partial from a template will automatically wrap the partial in the layout. I think this is because the render method automatically wraps a view in the layout if the layout exists, rather than checking if the first character is an underscore and

Re: using reststop with tilt

2010-07-09 Thread Philippe Monnet
For issue #1: I think I added the change on line 166( when committing my last changes for gem 0.5.3) to check for partials in the normal flow of restop_render. Could you verify you have the latest? For issue #2: what does your %=render ... % code looks like? Is only the name of the partial

Re: using reststop with tilt

2010-07-09 Thread David Susco
I do have the latest reststop gem, but the problem occurs when I'm *not* using reststop. The regular camping render method does not check for the _, where as the reststop render does. Line 166 is reststop is working, but there's no equivalent logic (that I can see) in camping render. I've tried

Re: using reststop with tilt

2010-07-09 Thread Magnus Holm
Should we apply a patch like this? diff --git a/lib/camping-unabridged.rb b/lib/camping-unabridged.rb index 636ad6f..f3195b3 100644 --- a/lib/camping-unabridged.rb +++ b/lib/camping-unabridged.rb @@ -272,7 +272,7 @@ module Camping def render(v, o={}, b) if t = lookup(v) s =

Re: using reststop with tilt

2010-07-09 Thread Philippe Monnet
Yes I think the first patch makes sense to filter out partials from the process of applying the layout. For the second patch now I get why Dave's parameters were not being used. So now your change would send *a . Cool. Dave do you want to try that out? And then Magnus can go ahead and apply it

Re: using reststop with tilt

2010-07-09 Thread David Susco
Thanks Magnus, those changes make sense to me. I can test them out no problem, just not until Monday. I'll send out another e-mail then. Thanks, Dave On Fri, Jul 9, 2010 at 5:30 PM, Philippe Monnet r...@monnet-usa.com wrote: Yes I think the first patch makes sense to filter out partials from

Re: using reststop with tilt

2010-07-08 Thread David Susco
Thanks Philippe, it's working great. Has anyone gotten partials to work with Tilt? Dave On Wed, Jul 7, 2010 at 9:58 PM, Philippe Monnet r...@monnet-usa.com wrote: I fixed the issue in the basic_render method. At the time I worked on RESTstop I had done the minimum needed to make it work with

Re: using reststop with tilt

2010-07-07 Thread Philippe Monnet
I fixed the issue in the basic_render method. At the time I worked on RESTstop I had done the minimum needed to make it work with the new version of Camping. And when Tilt support was added I did not fully retrofit the code to make it work with Tilt templates. Problem corrected! Thanks David

Re: using reststop with tilt

2010-07-06 Thread David Susco
Still fooling around with this, no luck yet. Found some other things though. It seems I need to fully qualify controllers as arguments for URL and R methods when using Tilt (this is irrespective of whether I'm using reststop or not). Is there anything I can do to get around this? Also, is there

Re: using reststop with tilt

2010-07-06 Thread Philippe Monnet
Hi David, I will look into this (probably this week-end though) - as I actually did not try Tilt at the same time as RESTstop. On 7/6/2010 7:45 AM, David Susco wrote: Still fooling around with this, no luck yet. Found some other things though. It seems I need to fully qualify controllers as