Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Afkham Azeez 
Many improvements have been made before the review & also several code
review recommendations have already been incorporated. Please try to
incorporate all the remaining changes ASAP and religiously adhere to these
conventions & best practices. Also, since this is an Ant & Maven plugin, I
think you should develop the project in an IDE independent manner. At the
moment, some parts of it are tied to Eclipse.

Thanks
Azeez

On Mon, Dec 13, 2010 at 10:41 PM, Harshana Martin  wrote:

> This code in the crucible review was committed to it last Friday and I have
> done lot of improvements to the code after that. But those changes are not
> synced here. But the code needs to be improved further and will do the rest
> of the improvements ASAP as instructed by Azeez, Ruwan and others.
>
> Thanks and Regards,
> Harshana
>
>
> On Mon, Dec 13, 2010 at 10:21 PM, Afkham Azeez  wrote:
>
>> Please revisit my  WSO2 Software Development Process presentation [1]
>>
>> 1.
>> https://docs.google.com/a/wso2.com/present/edit?id=0AXW7aoJmJW4wZGYzMnc2djJfMzVmd3M0bTNoZw&hl=en
>>
>> 
>>
>> On Mon, Dec 13, 2010 at 10:09 PM, Harshana Martin wrote:
>>
>>> Hi Azeez,
>>>
>>> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>>>
 Please revisit the Crucible component and check out my comments. There
 are several convention violations in some of this code. Please take a look
 and fix it ASAP.
>>>
>>>
>>> Sure. There were some coding conventions identified during the review.
>>> E.g: To use braces each and every time possible. Will improve the code
>>> asap.
>>>

 Thanks
 Azeez


 On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:

> Notes of this code review was recorded in the crucible project itself
> and the link for the crucible project is:
> https://wso2.org/crucible/cru/COMPONENT-14
>
> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin 
> wrote:
>
>>  This event has been changed.
>> more details 
>> »
>> Group A - Code Review
>> *Changed: *This core review will be on Ant and Maven integration with
>> C-App. You can find the crucible project for the core view at
>> https://wso2.org/crucible/cru/COMPONENT-14
>> .
>> *When*
>> Mon Dec 13 10am – 11:30am Colombo
>> *Where*
>> 3rd Floor (map )
>> *Calendar*
>> carbon-dev@wso2.org
>> *Who*
>>  •
>> Harshana Martin - organizer
>> •
>> Selvaratnam Uthaiyashankar
>> •
>> Supun Kamburugamuwa
>> •
>> carbon-dev@wso2.org
>>
>> Going?   
>> *Yes-
>> Maybe-
>> No
>> *more options 
>> »
>>
>> Invitation from Google Calendar 
>>
>> You are receiving this courtesy email at the account
>> carbon-dev@wso2.org because you are an attendee of this event.
>>
>> To stop receiving future notifications for this event, decline this
>> event. Alternatively you can sign up for a Google account at
>> https://www.google.com/calendar/ and control your notification
>> settings for your entire calendar.
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


 --
 *Afkham Azeez*
 Senior Softwa

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Sanjiva Weerawarana 
I think Azeez's point is that FindBugs needs to be run (and suggested
improvements made) AND code verified to follow the coding conventions
*BEFORE* the code review. That way time is not wasted on mundane things!

Sanjiva.

On Mon, Dec 13, 2010 at 10:41 PM, Harshana Martin  wrote:

> This code in the crucible review was committed to it last Friday and I have
> done lot of improvements to the code after that. But those changes are not
> synced here. But the code needs to be improved further and will do the rest
> of the improvements ASAP as instructed by Azeez, Ruwan and others.
>
> Thanks and Regards,
> Harshana
>
>
> On Mon, Dec 13, 2010 at 10:21 PM, Afkham Azeez  wrote:
>
>> Please revisit my  WSO2 Software Development Process presentation [1]
>>
>> 1.
>> https://docs.google.com/a/wso2.com/present/edit?id=0AXW7aoJmJW4wZGYzMnc2djJfMzVmd3M0bTNoZw&hl=en
>>
>> 
>>
>> On Mon, Dec 13, 2010 at 10:09 PM, Harshana Martin wrote:
>>
>>> Hi Azeez,
>>>
>>> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>>>
 Please revisit the Crucible component and check out my comments. There
 are several convention violations in some of this code. Please take a look
 and fix it ASAP.
>>>
>>>
>>> Sure. There were some coding conventions identified during the review.
>>> E.g: To use braces each and every time possible. Will improve the code
>>> asap.
>>>

 Thanks
 Azeez


 On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:

> Notes of this code review was recorded in the crucible project itself
> and the link for the crucible project is:
> https://wso2.org/crucible/cru/COMPONENT-14
>
> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin 
> wrote:
>
>>  This event has been changed.
>> more details 
>> »
>> Group A - Code Review
>> *Changed: *This core review will be on Ant and Maven integration with
>> C-App. You can find the crucible project for the core view at
>> https://wso2.org/crucible/cru/COMPONENT-14
>> .
>> *When*
>> Mon Dec 13 10am – 11:30am Colombo
>> *Where*
>> 3rd Floor (map )
>> *Calendar*
>> carbon-dev@wso2.org
>> *Who*
>>  •
>> Harshana Martin - organizer
>> •
>> Selvaratnam Uthaiyashankar
>> •
>> Supun Kamburugamuwa
>> •
>> carbon-dev@wso2.org
>>
>> Going?   
>> *Yes-
>> Maybe-
>> No
>> *more options 
>> »
>>
>> Invitation from Google Calendar 
>>
>> You are receiving this courtesy email at the account
>> carbon-dev@wso2.org because you are an attendee of this event.
>>
>> To stop receiving future notifications for this event, decline this
>> event. Alternatively you can sign up for a Google account at
>> https://www.google.com/calendar/ and control your notification
>> settings for your entire calendar.
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


 --
 *Afkham Azeez*
 Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com
 ,
 *
 *
 *Member; Apache Software Foundation; 
 **http://www.apache.org/*
 *
 email: **az

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Harshana Martin 
This code in the crucible review was committed to it last Friday and I have
done lot of improvements to the code after that. But those changes are not
synced here. But the code needs to be improved further and will do the rest
of the improvements ASAP as instructed by Azeez, Ruwan and others.

Thanks and Regards,
Harshana

On Mon, Dec 13, 2010 at 10:21 PM, Afkham Azeez  wrote:

> Please revisit my  WSO2 Software Development Process presentation [1]
>
> 1.
> https://docs.google.com/a/wso2.com/present/edit?id=0AXW7aoJmJW4wZGYzMnc2djJfMzVmd3M0bTNoZw&hl=en
>
> 
>
> On Mon, Dec 13, 2010 at 10:09 PM, Harshana Martin wrote:
>
>> Hi Azeez,
>>
>> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>>
>>> Please revisit the Crucible component and check out my comments. There
>>> are several convention violations in some of this code. Please take a look
>>> and fix it ASAP.
>>
>>
>> Sure. There were some coding conventions identified during the review.
>> E.g: To use braces each and every time possible. Will improve the code
>> asap.
>>
>>>
>>> Thanks
>>> Azeez
>>>
>>>
>>> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>>>
 Notes of this code review was recorded in the crucible project itself
 and the link for the crucible project is:
 https://wso2.org/crucible/cru/COMPONENT-14

 On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:

>  This event has been changed.
> more details 
> »
> Group A - Code Review
> *Changed: *This core review will be on Ant and Maven integration with
> C-App. You can find the crucible project for the core view at
> https://wso2.org/crucible/cru/COMPONENT-14
> .
> *When*
> Mon Dec 13 10am – 11:30am Colombo
> *Where*
> 3rd Floor (map )
> *Calendar*
> carbon-dev@wso2.org
> *Who*
>  •
> Harshana Martin - organizer
> •
> Selvaratnam Uthaiyashankar
> •
> Supun Kamburugamuwa
> •
> carbon-dev@wso2.org
>
> Going?   
> *Yes-
> Maybe-
> No
> *more options 
> »
>
> Invitation from Google Calendar 
>
> You are receiving this courtesy email at the account
> carbon-dev@wso2.org because you are an attendee of this event.
>
> To stop receiving future notifications for this event, decline this
> event. Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification
> settings for your entire calendar.
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>

 ___
 Carbon-dev mailing list
 Carbon-dev@wso2.org
 https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev


>>>
>>>
>>> --
>>> *Afkham Azeez*
>>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com
>>> ,
>>> *
>>> *
>>> *Member; Apache Software Foundation; 
>>> **http://www.apache.org/*
>>> *
>>> email: **az...@wso2.com* * cell: +94 77 3320919
>>> blog: **http://blog.afkham.org* *
>>> twitter: **http://twitter.com/afkham_azeez*
>>> *
>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>> *
>>> *
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>
>>
>> --
>> Harshana Martin
>> Software Engineer
>> WSO2 Inc.
>> Web:http://wso2.com
>>
>> Mobile: +94 71606

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Afkham Azeez 
Please revisit my  WSO2 Software Development Process presentation [1]

1.
https://docs.google.com/a/wso2.com/present/edit?id=0AXW7aoJmJW4wZGYzMnc2djJfMzVmd3M0bTNoZw&hl=en


On Mon, Dec 13, 2010 at 10:09 PM, Harshana Martin  wrote:

> Hi Azeez,
>
> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>
>> Please revisit the Crucible component and check out my comments. There are
>> several convention violations in some of this code. Please take a look and
>> fix it ASAP.
>
>
> Sure. There were some coding conventions identified during the review. E.g:
> To use braces each and every time possible. Will improve the code asap.
>
>>
>> Thanks
>> Azeez
>>
>>
>> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>>
>>> Notes of this code review was recorded in the crucible project itself and
>>> the link for the crucible project is:
>>> https://wso2.org/crucible/cru/COMPONENT-14
>>>
>>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>>>
  This event has been changed.
 more details 
 »
 Group A - Code Review
 *Changed: *This core review will be on Ant and Maven integration with
 C-App. You can find the crucible project for the core view at
 https://wso2.org/crucible/cru/COMPONENT-14
 .
 *When*
 Mon Dec 13 10am – 11:30am Colombo
 *Where*
 3rd Floor (map )
 *Calendar*
 carbon-dev@wso2.org
 *Who*
  •
 Harshana Martin - organizer
 •
 Selvaratnam Uthaiyashankar
 •
 Supun Kamburugamuwa
 •
 carbon-dev@wso2.org

 Going?   
 *Yes-
 Maybe-
 No
 *more options 
 »

 Invitation from Google Calendar 

 You are receiving this courtesy email at the account
 carbon-dev@wso2.org because you are an attendee of this event.

 To stop receiving future notifications for this event, decline this
 event. Alternatively you can sign up for a Google account at
 https://www.google.com/calendar/ and control your notification settings
 for your entire calendar.

 ___
 Carbon-dev mailing list
 Carbon-dev@wso2.org
 https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev


>>>
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
>> *
>> *
>> *Member; Apache Software Foundation; 
>> **http://www.apache.org/*
>> *
>> email: **az...@wso2.com* * cell: +94 77 3320919
>> blog: **http://blog.afkham.org* *
>> twitter: **http://twitter.com/afkham_azeez*
>> *
>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>> *
>> *
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> Harshana Martin
> Software Engineer
> WSO2 Inc.
> Web:http://wso2.com
>
> Mobile: +94 716062650
> Blog: http://harshana05.blogspot.com
> Profile: https://www.google.com/profiles/harshana05
>
>


-- 
*Afkham Azeez*
Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
*
*
*Member; Apache Software Foundation;
**http://www.apache.org/*
*
email: **az...@wso2.com* * cell: +94 77 3320919
blog: **http://blog.afkham.org* *
twitter: **http://twitter.com/afkham_azeez*
*
linked-in: **http://lk.linkedin.com/i

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Harshana Martin 
On Mon, Dec 13, 2010 at 8:57 PM, Afkham Azeez  wrote:

> Was FindBugs run on this code?


Yes. Findbugs was ran against this code. It did not complaint about other
than several minor issues. Will show you it to you tomorrow.

>
> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>
>> Please revisit the Crucible component and check out my comments. There are
>> several convention violations in some of this code. Please take a look and
>> fix it ASAP.
>>
>> Thanks
>> Azeez
>>
>>
>> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>>
>>> Notes of this code review was recorded in the crucible project itself and
>>> the link for the crucible project is:
>>> https://wso2.org/crucible/cru/COMPONENT-14
>>>
>>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>>>
  This event has been changed.
 more details 
 »
 Group A - Code Review
 *Changed: *This core review will be on Ant and Maven integration with
 C-App. You can find the crucible project for the core view at
 https://wso2.org/crucible/cru/COMPONENT-14
 .
 *When*
 Mon Dec 13 10am – 11:30am Colombo
 *Where*
 3rd Floor (map )
 *Calendar*
 carbon-dev@wso2.org
 *Who*
  •
 Harshana Martin - organizer
 •
 Selvaratnam Uthaiyashankar
 •
 Supun Kamburugamuwa
 •
 carbon-dev@wso2.org

 Going?   
 *Yes-
 Maybe-
 No
 *more options 
 »

 Invitation from Google Calendar 

 You are receiving this courtesy email at the account
 carbon-dev@wso2.org because you are an attendee of this event.

 To stop receiving future notifications for this event, decline this
 event. Alternatively you can sign up for a Google account at
 https://www.google.com/calendar/ and control your notification settings
 for your entire calendar.

 ___
 Carbon-dev mailing list
 Carbon-dev@wso2.org
 https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev


>>>
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
>> *
>> *
>> *Member; Apache Software Foundation; 
>> **http://www.apache.org/*
>> *
>> email: **az...@wso2.com* * cell: +94 77 3320919
>> blog: **http://blog.afkham.org* *
>> twitter: **http://twitter.com/afkham_azeez*
>> *
>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>> *
>> *
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> *Afkham Azeez*
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> *
> *
> *Member; Apache Software Foundation; 
> **http://www.apache.org/*
> *
> email: **az...@wso2.com* * cell: +94 77 3320919
> blog: **http://blog.afkham.org* *
> twitter: **http://twitter.com/afkham_azeez*
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>


-- 
Harshana Martin
Software Engineer
WSO2 Inc.
Web:http://wso2.com

Mobile: +94 716062650
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Harshana Martin 
Hi Azeez,

On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:

> Please revisit the Crucible component and check out my comments. There are
> several convention violations in some of this code. Please take a look and
> fix it ASAP.


Sure. There were some coding conventions identified during the review. E.g:
To use braces each and every time possible. Will improve the code asap.

>
> Thanks
> Azeez
>
>
> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>
>> Notes of this code review was recorded in the crucible project itself and
>> the link for the crucible project is:
>> https://wso2.org/crucible/cru/COMPONENT-14
>>
>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>>
>>>  This event has been changed.
>>> more details 
>>> »
>>> Group A - Code Review
>>> *Changed: *This core review will be on Ant and Maven integration with
>>> C-App. You can find the crucible project for the core view at
>>> https://wso2.org/crucible/cru/COMPONENT-14
>>> .
>>> *When*
>>> Mon Dec 13 10am – 11:30am Colombo
>>> *Where*
>>> 3rd Floor (map )
>>> *Calendar*
>>> carbon-dev@wso2.org
>>> *Who*
>>>  •
>>> Harshana Martin - organizer
>>> •
>>> Selvaratnam Uthaiyashankar
>>> •
>>> Supun Kamburugamuwa
>>> •
>>> carbon-dev@wso2.org
>>>
>>> Going?   
>>> *Yes-
>>> Maybe-
>>> No
>>> *more options 
>>> »
>>>
>>> Invitation from Google Calendar 
>>>
>>> You are receiving this courtesy email at the account 
>>> carbon-...@wso2.orgbecause you are an attendee of this event.
>>>
>>> To stop receiving future notifications for this event, decline this
>>> event. Alternatively you can sign up for a Google account at
>>> https://www.google.com/calendar/ and control your notification settings
>>> for your entire calendar.
>>>
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
>
> --
> *Afkham Azeez*
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> *
> *
> *Member; Apache Software Foundation; 
> **http://www.apache.org/*
> *
> email: **az...@wso2.com* * cell: +94 77 3320919
> blog: **http://blog.afkham.org* *
> twitter: **http://twitter.com/afkham_azeez*
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>


-- 
Harshana Martin
Software Engineer
WSO2 Inc.
Web:http://wso2.com

Mobile: +94 716062650
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Samisa Abeysinghe 
On Mon, Dec 13, 2010 at 8:57 PM, Afkham Azeez  wrote:

> Was FindBugs run on this code?


It does not look like it was run :(

We should not review any code that was not run through find bugs. It is a
waste of time.

It should be the first step in the review that the code owner run find bugs
and show to others at the start of the review.


>
> On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:
>
>> Please revisit the Crucible component and check out my comments. There are
>> several convention violations in some of this code. Please take a look and
>> fix it ASAP.
>>
>> Thanks
>> Azeez
>>
>>
>> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>>
>>> Notes of this code review was recorded in the crucible project itself and
>>> the link for the crucible project is:
>>> https://wso2.org/crucible/cru/COMPONENT-14
>>>
>>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>>>
  This event has been changed.
 more details 
 »
 Group A - Code Review
 *Changed: *This core review will be on Ant and Maven integration with
 C-App. You can find the crucible project for the core view at
 https://wso2.org/crucible/cru/COMPONENT-14
 .
 *When*
 Mon Dec 13 10am – 11:30am Colombo
 *Where*
 3rd Floor (map )
 *Calendar*
 carbon-dev@wso2.org
 *Who*
  •
 Harshana Martin - organizer
 •
 Selvaratnam Uthaiyashankar
 •
 Supun Kamburugamuwa
 •
 carbon-dev@wso2.org

 Going?   
 *Yes-
 Maybe-
 No
 *more options 
 »

 Invitation from Google Calendar 

 You are receiving this courtesy email at the account
 carbon-dev@wso2.org because you are an attendee of this event.

 To stop receiving future notifications for this event, decline this
 event. Alternatively you can sign up for a Google account at
 https://www.google.com/calendar/ and control your notification settings
 for your entire calendar.

 ___
 Carbon-dev mailing list
 Carbon-dev@wso2.org
 https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev


>>>
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
>> *
>> *
>> *Member; Apache Software Foundation; 
>> **http://www.apache.org/*
>> *
>> email: **az...@wso2.com* * cell: +94 77 3320919
>> blog: **http://blog.afkham.org* *
>> twitter: **http://twitter.com/afkham_azeez*
>> *
>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>> *
>> *
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> *Afkham Azeez*
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> *
> *
> *Member; Apache Software Foundation; 
> **http://www.apache.org/*
> *
> email: **az...@wso2.com* * cell: +94 77 3320919
> blog: **http://blog.afkham.org* *
> twitter: **http://twitter.com/afkham_azeez*
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
> Thanks,
Samisa...

Samisa Abeysinghe
VP Engineering
WSO2 Inc.
http://wso2.com
http://wso2.org
_

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Afkham Azeez 
Was FindBugs run on this code?

On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez  wrote:

> Please revisit the Crucible component and check out my comments. There are
> several convention violations in some of this code. Please take a look and
> fix it ASAP.
>
> Thanks
> Azeez
>
>
> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe wrote:
>
>> Notes of this code review was recorded in the crucible project itself and
>> the link for the crucible project is:
>> https://wso2.org/crucible/cru/COMPONENT-14
>>
>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>>
>>>  This event has been changed.
>>> more details 
>>> »
>>> Group A - Code Review
>>> *Changed: *This core review will be on Ant and Maven integration with
>>> C-App. You can find the crucible project for the core view at
>>> https://wso2.org/crucible/cru/COMPONENT-14
>>> .
>>> *When*
>>> Mon Dec 13 10am – 11:30am Colombo
>>> *Where*
>>> 3rd Floor (map )
>>> *Calendar*
>>> carbon-dev@wso2.org
>>> *Who*
>>>  •
>>> Harshana Martin - organizer
>>> •
>>> Selvaratnam Uthaiyashankar
>>> •
>>> Supun Kamburugamuwa
>>> •
>>> carbon-dev@wso2.org
>>>
>>> Going?   
>>> *Yes-
>>> Maybe-
>>> No
>>> *more options 
>>> »
>>>
>>> Invitation from Google Calendar 
>>>
>>> You are receiving this courtesy email at the account 
>>> carbon-...@wso2.orgbecause you are an attendee of this event.
>>>
>>> To stop receiving future notifications for this event, decline this
>>> event. Alternatively you can sign up for a Google account at
>>> https://www.google.com/calendar/ and control your notification settings
>>> for your entire calendar.
>>>
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
>
> --
> *Afkham Azeez*
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> *
> *
> *Member; Apache Software Foundation; 
> **http://www.apache.org/*
> *
> email: **az...@wso2.com* * cell: +94 77 3320919
> blog: **http://blog.afkham.org* *
> twitter: **http://twitter.com/afkham_azeez*
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>


-- 
*Afkham Azeez*
Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
*
*
*Member; Apache Software Foundation;
**http://www.apache.org/*
*
email: **az...@wso2.com* * cell: +94 77 3320919
blog: **http://blog.afkham.org* *
twitter: **http://twitter.com/afkham_azeez*
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-13 Thread Afkham Azeez 
Please revisit the Crucible component and check out my comments. There are
several convention violations in some of this code. Please take a look and
fix it ASAP.

Thanks
Azeez

On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe  wrote:

> Notes of this code review was recorded in the crucible project itself and
> the link for the crucible project is:
> https://wso2.org/crucible/cru/COMPONENT-14
>
> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin wrote:
>
>>  This event has been changed.
>> more details 
>> »
>> Group A - Code Review
>> *Changed: *This core review will be on Ant and Maven integration with
>> C-App. You can find the crucible project for the core view at
>> https://wso2.org/crucible/cru/COMPONENT-14
>> .
>> *When*
>> Mon Dec 13 10am – 11:30am Colombo
>> *Where*
>> 3rd Floor (map )
>> *Calendar*
>> carbon-dev@wso2.org
>> *Who*
>>  •
>> Harshana Martin - organizer
>> •
>> Selvaratnam Uthaiyashankar
>> •
>> Supun Kamburugamuwa
>> •
>> carbon-dev@wso2.org
>>
>> Going?   
>> *Yes-
>> Maybe-
>> No
>> *more options 
>> »
>>
>> Invitation from Google Calendar 
>>
>> You are receiving this courtesy email at the account 
>> carbon-...@wso2.orgbecause you are an attendee of this event.
>>
>> To stop receiving future notifications for this event, decline this event.
>> Alternatively you can sign up for a Google account at
>> https://www.google.com/calendar/ and control your notification settings
>> for your entire calendar.
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
*Afkham Azeez*
Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
*
*
*Member; Apache Software Foundation;
**http://www.apache.org/*
*
email: **az...@wso2.com* * cell: +94 77 3320919
blog: **http://blog.afkham.org* *
twitter: **http://twitter.com/afkham_azeez*
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Updated Invitation: Group A - Code Review @ Mon Dec 13 10am - 11:30am (carbon-dev@wso2.org)

2010-12-12 Thread Hasini Gunasinghe 
Notes of this code review was recorded in the crucible project itself and
the link for the crucible project is:
https://wso2.org/crucible/cru/COMPONENT-14

On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin  wrote:

> This event has been changed.
> more details 
> »
> Group A - Code Review
> *Changed: *This core review will be on Ant and Maven integration with
> C-App. You can find the crucible project for the core view at
> https://wso2.org/crucible/cru/COMPONENT-14
> .
> *When*
> Mon Dec 13 10am – 11:30am Colombo
> *Where*
> 3rd Floor (map )
> *Calendar*
> carbon-dev@wso2.org
> *Who*
> •
> Harshana Martin - organizer
> •
> Selvaratnam Uthaiyashankar
> •
> Supun Kamburugamuwa
> •
> carbon-dev@wso2.org
>
> Going?   
> *Yes-
> Maybe-
> No
> *more options 
> »
>
> Invitation from Google Calendar 
>
> You are receiving this courtesy email at the account 
> carbon-...@wso2.orgbecause you are an attendee of this event.
>
> To stop receiving future notifications for this event, decline this event.
> Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification settings
> for your entire calendar.
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev