Re: [Catalyst] Problems with Encoding support in Catalyst.

2017-01-10 Thread John Napiorkowski
Hi Bill, is_utf8 probably doesn't do what you think it does: http://stackoverflow.com/questions/14579560/am-i-using-utf8is-utf8-correctly If we are throwing errors here that we'd prefer handled differently, see if you can workup a test case and I will bounce it around. The Binmode problem is

Re: [Catalyst] Problems with Encoding support in Catalyst.

2017-01-08 Thread Bill Moseley
On Sat, Jan 7, 2017 at 9:55 PM, Bill Moseley wrote: > > # Let it be set to undef > if (my $wanted = shift) { > $encoding = Encode::find_encoding($wanted) > or Carp::croak( qq/Unknown encoding '$wanted'/ ); >

[Catalyst] Problems with Encoding support in Catalyst.

2017-01-07 Thread Bill Moseley
I just finally removed my custom encoding code to use the built-in code Catalyst now provides to decode input data and encode output. But, I came across two issues that I wanted to get some feedback on. First one is simple. This code will die if $value is already decoded. Any reason not to