Re: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-29 Thread Tomas Doran
On 26 Jun 2009, at 23:19, Byron Young wrote: Alrighty, here you go, patch + test are attached. There are based off the 5.71001 svn head because that's what I have currently. 5.8's uri_for() looks the same, so it should apply there as well, but let me know if you need another one from

RE: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-29 Thread Byron Young
Tomas Doran wrote on 2009-06-29: On 26 Jun 2009, at 23:19, Byron Young wrote: Alrighty, here you go, patch + test are attached. There are based off the 5.71001 svn head because that's what I have currently. 5.8's uri_for() looks the same, so it should apply there as well, but let me know

Re: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-29 Thread Tomas Doran
On 30 Jun 2009, at 00:31, Byron Young wrote: If you don't mind, though, can you explain what you mean about the 'unsafe each'? If your application code half iterates through the params hash with each before calling uri_for, then the param copy would only copy the second half of the hash

RE: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-29 Thread Byron Young
Tomas Doran wrote on 2009-06-29: On 30 Jun 2009, at 00:31, Byron Young wrote: If you don't mind, though, can you explain what you mean about the 'unsafe each'? If your application code half iterates through the params hash with each before calling uri_for, then the param copy would only

[Catalyst] Re: uri_for() corrupts query parameters hash for caller

2009-06-29 Thread Aristotle Pagaltzis
* Tomas Doran bobtf...@bobtfish.net [2009-06-30 02:35]: If your application code half iterates through the params hash with each before calling uri_for, then the param copy would only copy the second half of the hash (as each has an internal iterator). FWIW you can reset the iterator using

Re: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-26 Thread Tomas Doran
Byron Young wrote: I know people have been busy (I think there were some perl conferences lately?) and I think my issue slipped through the cracks. Just wanted to know what people thought about this and whether I should submit my patch or take a different approach. Sorry for dropping

RE: [Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-26 Thread Byron Young
Tomas Doran wrote on 2009-06-26: Byron Young wrote: I know people have been busy (I think there were some perl conferences lately?) and I think my issue slipped through the cracks. Just wanted to know what people thought about this and whether I should submit my patch or take a different

[Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-25 Thread Byron Young
Byron Young wrote on 2009-06-12: Byron Young wrote on 2009-06-12: Hey everybody, I ran into an issue at $work where we keep passing the same $query_params hashref to a number of uri_for() calls successively, but if there are characters in the query params that need to be escaped they get

[Catalyst] RE: uri_for() corrupts query parameters hash for caller

2009-06-12 Thread Byron Young
Byron Young wrote on 2009-06-12: Hey everybody, I ran into an issue at $work where we keep passing the same $query_params hashref to a number of uri_for() calls successively, but if there are characters in the query params that need to be escaped they get escaped each time, leading to