Re: [Catalyst] Change in $c->engine->prepare_parameters

2012-08-07 Thread Bill Moseley
Did this help? On Sat, Aug 4, 2012 at 6:19 PM, Bill Moseley wrote: > See attached. > > Let me know if you want something else. > > I'm mixed on of the clear should be private. I made it that way, but I > wonder if there could be a use case to reset the parameters so next time > $c->req->paramet

Re: [Catalyst] Change in $c->engine->prepare_parameters

2012-08-04 Thread Bill Moseley
See attached. Let me know if you want something else. I'm mixed on of the clear should be private. I made it that way, but I wonder if there could be a use case to reset the parameters so next time $c->req->parameters is called they get built again. I guess in that case why wouldn't they just

Re: [Catalyst] Change in $c->engine->prepare_parameters

2012-08-04 Thread Bill Moseley
I'll work on a patch and docs, yes. On Sat, Aug 4, 2012 at 6:53 AM, Tomas Doran wrote: > > On 3 Aug 2012, at 14:39, Bill Moseley wrote: > > > What it doesn't do any more is set $c->req->parameters when called > directly, only when called as a builder. > > > > > > I don't think prepare_parameters

Re: [Catalyst] Change in $c->engine->prepare_parameters

2012-08-04 Thread Tomas Doran
On 3 Aug 2012, at 14:39, Bill Moseley wrote: > What it doesn't do any more is set $c->req->parameters when called directly, > only when called as a builder. > > > I don't think prepare_parameters should be both a builder AND a method. > What about this approach: +1, except I think the clea