Re: [Catalyst] Change in $c->engine->prepare_parameters
See attached. Let me know if you want something else. I'm mixed on of the clear should be private. I made it that way, but I wonder if there could be a use case to reset the parameters so next time $c->req->parameters is called they get built again. I guess in that case why wouldn't they just call $c->prepare_parameters again? On Sat, Aug 4, 2012 at 6:53 AM, Tomas Doran wrote: > > On 3 Aug 2012, at 14:39, Bill Moseley wrote: > > > What it doesn't do any more is set $c->req->parameters when called > directly, only when called as a builder. > > > > > > I don't think prepare_parameters should be both a builder AND a method. > What about this approach: > > +1, except I think the clearer should be _clear_parameters - we don't want > to add a new public method for this if it can be avoided. > > Fancy making a 'proper' patch someone can apply which does these changes > and updates the relevant doc? > > Cheers > t0m > > > ___ > List: Catalyst@lists.scsys.co.uk > Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst > Searchable archive: > http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ > Dev site: http://dev.catalyst.perl.org/ > -- Bill Moseley mose...@hank.org prepare_parameters.diff Description: Binary data live_engine_request_prepare_parameters.t Description: Troff document ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
Re: [Catalyst] Change in $c->engine->prepare_parameters
I'll work on a patch and docs, yes. On Sat, Aug 4, 2012 at 6:53 AM, Tomas Doran wrote: > > On 3 Aug 2012, at 14:39, Bill Moseley wrote: > > > What it doesn't do any more is set $c->req->parameters when called > directly, only when called as a builder. > > > > > > I don't think prepare_parameters should be both a builder AND a method. > What about this approach: > > +1, except I think the clearer should be _clear_parameters - we don't want > to add a new public method for this if it can be avoided. > > Fancy making a 'proper' patch someone can apply which does these changes > and updates the relevant doc? > > Cheers > t0m > > > ___ > List: Catalyst@lists.scsys.co.uk > Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst > Searchable archive: > http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ > Dev site: http://dev.catalyst.perl.org/ > -- Bill Moseley mose...@hank.org ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
Re: [Catalyst] Change in $c->engine->prepare_parameters
On 3 Aug 2012, at 14:39, Bill Moseley wrote: > What it doesn't do any more is set $c->req->parameters when called directly, > only when called as a builder. > > > I don't think prepare_parameters should be both a builder AND a method. > What about this approach: +1, except I think the clearer should be _clear_parameters - we don't want to add a new public method for this if it can be avoided. Fancy making a 'proper' patch someone can apply which does these changes and updates the relevant doc? Cheers t0m ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
