Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-10-31 Thread Léon Brocard
2008/5/17 Leon Brocard [EMAIL PROTECTED]:

 Thanks for the investigation Thomas, but I'd like to hold off until
 someone actually fixes the real problems and quietens the warnings
 using understanding.

Thanks to petdance, mst and dakkar, we finally have a working
Test::WWW::Mechanize::Catalyst:

http://search.cpan.org/dist/Test-WWW-Mechanize-Catalyst/

Phew, that took a while. Leon

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-16 Thread Thomas Klausner
Hi!

On Thu, May 15, 2008 at 10:20:23AM -0400, John Goulah wrote:
 
 Since these fix tests, will these modules get patched and released
 with this applied?

Hm, actually I only notified Leon about the patches. I will also submit 
the patches directly to Andy (for WWW::Mechanize)

-- 
#!/usr/bin/perl  http://domm.plix.at
for(ref bless{},just'another'perl'hacker){s-:+-$-gprint$_.$/}

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-16 Thread Leon Brocard
2008/5/15 John Goulah [EMAIL PROTECTED]:

 Since these fix tests, will these modules get patched and released
 with this applied?

Thanks for the investigation Thomas, but I'd like to hold off until
someone actually fixes the real problems and quietens the warnings
using understanding.

For now just downgrade LWP.

Regards, Leon

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-15 Thread Thomas Klausner
Hi!

On Sun, May 11, 2008 at 07:10:27PM +0100, Leon Brocard wrote:
 2008/5/10 Daniel McBrearty [EMAIL PROTECTED]:
 
  I'd like Leon's opinion on this. Forwarding to him again.
 
 I understand many bits of it but have given up trying to get it
 working. I would love a patch which passes tests on both old and new
 lib-www-perls.

Today we where hit by this, and I dug into the code...

The problems seems to lie in WWW::Mechanize and 
Test::WWW::Mechanize::Catalyst.

I was able to (sort of) fix it with the attached two patches.

T:W:M:C tests work after those patches (as do our tests...), but 
WWW::Mechanize spews some Parsing of undecoded UTF-8 will give garbage 
when decoding entitie warnings. And I'm not in the mood for utf8 
debugging ...

I have to say that I did not analyse the whole problem, and in fact we 
just downgrade to libwww-perl-5.808. But if these findings help someone 
with deeper knowledge to really solve the problem, I'd be delighted!

-- 
#!/usr/bin/perl  http://domm.plix.at
for(ref bless{},just'another'perl'hacker){s-:+-$-gprint$_.$/}
diff -ur WWW-Mechanize-1.34/lib/WWW/Mechanize.pm WWW-Mechanize-1.34-patched/lib/WWW/Mechanize.pm
--- WWW-Mechanize-1.34/lib/WWW/Mechanize.pm	2007-12-10 07:31:20.0 +0100
+++ WWW-Mechanize-1.34-patched/lib/WWW/Mechanize.pm	2008-05-15 13:28:03.0 +0200
@@ -2148,7 +2148,7 @@
 # See docs in HTTP::Message for details. Do we need to expose the options there? 
 # use charset = 'none' because while we want LWP to handle Content-Encoding for 
 # the auto-gzipping with Compress::Zlib we don't want it messing with charset
-my $content = $res-decoded_content( charset = 'none' );
+my $content = $res-decoded_content();
 $content = $res-content if (not defined $content);
 
 $content .= _taintedness();
Only in WWW-Mechanize-1.34-patched/: Makefile.old
diff -ur WWW-Mechanize-1.34/t/local/log-server WWW-Mechanize-1.34-patched/t/local/log-server
--- WWW-Mechanize-1.34/t/local/log-server	2007-08-27 02:47:30.0 +0200
+++ WWW-Mechanize-1.34-patched/t/local/log-server	2008-05-15 13:14:10.0 +0200
@@ -88,7 +88,7 @@
   a href=/foo1.save_log_server_test.tmpLink foo1.save_log_server_test.tmp/a
   a href=/foo2.save_log_server_test.tmpLink foo2.save_log_server_test.tmp/a
   a href=/foo3.save_log_server_test.tmpLink foo3.save_log_server_test.tmp/a
-  a href=/o-umlautLöschen -- testing for o-umlaut./a
+  a href=/o-umlautLöschen -- testing for o-umlaut./a
   a href=/o-umlaut-encodedStouml;sberg -- testing for encoded o-umlaut./a
 
   table
diff -ru Test-WWW-Mechanize-Catalyst-0.42/lib/Test/WWW/Mechanize/Catalyst.pm Test-WWW-Mechanize-Catalyst-0.42-patched/lib/Test/WWW/Mechanize/Catalyst.pm
--- Test-WWW-Mechanize-Catalyst-0.42/lib/Test/WWW/Mechanize/Catalyst.pm	2008-04-29 21:25:55.0 +0200
+++ Test-WWW-Mechanize-Catalyst-0.42-patched/lib/Test/WWW/Mechanize/Catalyst.pm	2008-05-15 13:30:44.0 +0200
@@ -89,7 +89,6 @@
 
  # For some reason Test::WWW::Mechanize uses $response-content everywhere
  # instead of $response-decoded_content;
-$response-content( $response-decoded_content );
 }
 
 return $response;
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-11 Thread Leon Brocard
2008/5/10 Daniel McBrearty [EMAIL PROTECTED]:

 I'd like Leon's opinion on this. Forwarding to him again.

I understand many bits of it but have given up trying to get it
working. I would love a patch which passes tests on both old and new
lib-www-perls.

Leon

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-10 Thread Daniel McBrearty
 I think there was some discussion over the same error in the POE HTTP
 client over on perlmonks that included a this is the line of code that
 is wrong. I can't find the link offhand though.

well, I see really three places to look at this:

1. in HTTP::Message - IMO the check on the content is fine, but there
is really no need to die on failure, at least not until the rest of
the codebase gets fixed. Hence my short term fix of just removing
that. Bah.

2. in Test::WWW:Mechanize::Catalyst , you get:

# For some reason Test::WWW::Mechanize uses $response-content everywhere
# instead of $response-decoded_content;
$response-content( $response-decoded_content );

which is the line that causes problems up the chain (I think that the
content check that happens in HTTP::Message-new() is not an issue).

So here, the question is, *why*? Is the right fix for T:W:M to change
to using decoded_content and remove this line? Or just remove this
line anyway? Or is there another issue?

I'd like Leon's opinion on this. Forwarding to him again.

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-09 Thread Matt S Trout
On Wed, May 07, 2008 at 10:51:37PM +0200, Daniel McBrearty wrote:
 Not sure who that's pointed at Matt, but if you mean me, sorry for that.

No, I meant John and his soapbox.
 
 In all honesty, if I could've worked out *what* needed fixing and
 where, I would have done so. What I did was at least try to indicate
 to people where the error was coming from and why, and what they might
 do temporarily in order to get a workaround. In the absence of any
 actual understanding of *why* the changes which triggered the problem
 were made, trying to actually implement a fix didn't seem a very good
 idea.

I think there was some discussion over the same error in the POE HTTP
client over on perlmonks that included a this is the line of code that
is wrong. I can't find the link offhand though.

-- 
  Matt S Trout   Need help with your Catalyst or DBIx::Class project?
   Technical Directorhttp://www.shadowcat.co.uk/catalyst/
 Shadowcat Systems Ltd.  Want a managed development or deployment platform?
http://chainsawblues.vox.com/http://www.shadowcat.co.uk/servers/

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-07 Thread Daniel McBrearty
Not sure who that's pointed at Matt, but if you mean me, sorry for that.

In all honesty, if I could've worked out *what* needed fixing and
where, I would have done so. What I did was at least try to indicate
to people where the error was coming from and why, and what they might
do temporarily in order to get a workaround. In the absence of any
actual understanding of *why* the changes which triggered the problem
were made, trying to actually implement a fix didn't seem a very good
idea.

At any rate, the suggestion of some kind of stable/testing rating for
module releases sounds like a pretty good idea.


 Not when you're that far down the dependency chain.

 Anyway, this thread was started to try and help get the fallout fixed,
 not for you to posture. Either write code, shut up, or start a separate
 thread so I can safely killfile it.


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-06 Thread Zbigniew Lukasiak
On Mon, May 5, 2008 at 11:12 PM, Daniel McBrearty
[EMAIL PROTECTED] wrote:
 If you don't want new versions of modules, then *don't upgrade them*.

  and when you (or a total newcomer to the language/framework) do a
  *new* install? and the latest greatest is broken right out of the
  box? looks great, hey?

  The code may have been broken - but not so broken that it couldn't
  work (acceptably) well in the last N releases. But, hey, all of a
  sudden, it must be changed *now*.

There is a proposal from Michael Schwern for a Debian-like releases
(unstable, test, stable and old-stable)
http://www.perlfoundation.org/perl5/index.cgi?cpan_stability_project .
 I just thought this might be interesting to you.

-- 
Zbigniew Lukasiak
http://brudnopis.blogspot.com/

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-06 Thread Matt S Trout
On Mon, May 05, 2008 at 03:46:09PM -0500, Jonathan Rockway wrote:
 * On Mon, May 05 2008, Daniel McBrearty wrote:
  tht's reasonable.
 
  what is not so reasonable is suddenly deciding that you are going to
  *croak* on something which you didn't even test for with previous
  releases.
 
  A warning would have been fine, at least for half a year or so.
 
 In that case we would be having this exact discussion 6 months from
 now.  Breaking broken code is always good.  +1 for HTTP::Message.

Not when you're that far down the dependency chain.

Anyway, this thread was started to try and help get the fallout fixed,
not for you to posture. Either write code, shut up, or start a separate
thread so I can safely killfile it.

-- 
  Matt S Trout   Need help with your Catalyst or DBIx::Class project?
   Technical Directorhttp://www.shadowcat.co.uk/catalyst/
 Shadowcat Systems Ltd.  Want a managed development or deployment platform?
http://chainsawblues.vox.com/http://www.shadowcat.co.uk/servers/

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-05 Thread Daniel McBrearty
If you don't want new versions of modules, then *don't upgrade them*.

and when you (or a total newcomer to the language/framework) do a
*new* install? and the latest greatest is broken right out of the
box? looks great, hey?

The code may have been broken - but not so broken that it couldn't
work (acceptably) well in the last N releases. But, hey, all of a
sudden, it must be changed *now*.

Dogmatism.

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-04 Thread Daniel McBrearty
yeah, I started setting up cat on a new system yesterday and hit this :-(

The salient line seems to be :
HTTP::Message content not bytes at lib/Test/WWW/Mechanize/Catalyst.pm
line 88

I will spend an hour or two on it now, as I hate force installing, but
am starting almost from scratch and don't have much intuition yet as
what this is about. Any pointers welcome ...

D

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-04 Thread Daniel McBrearty
OK, I walked through the code and found out roughly what is going on.
Hard to say where the real source of the bug is (could be at least two
modules) but I have a workaround which I am using (basically just to
remove the croak in HTTP::Message, a bit dirty but probably
harmless).

http://rt.cpan.org/Public/Bug/Display.html?id=34802

I forwarded this to Leon also.

HTH

D

On Sun, May 4, 2008 at 9:30 PM, Daniel McBrearty
[EMAIL PROTECTED] wrote:
 yeah, I started setting up cat on a new system yesterday and hit this :-(

 The salient line seems to be :
 HTTP::Message content not bytes at lib/Test/WWW/Mechanize/Catalyst.pm
 line 88

 I will spend an hour or two on it now, as I hate force installing, but
 am starting almost from scratch and don't have much intuition yet as
 what this is about. Any pointers welcome ...

 D




-- 
Daniel McBrearty
email : danielmcbrearty at gmail.com
http://www.engoi.com
http://danmcb.vox.com
http://danmcb.blogger.com
find me on linkedin and facebook
BTW : 0873928131

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] Anybody who fancies some LWP poking ...

2008-05-04 Thread Ashley

There was a recent SoPW on PerlMonks about this. Seems HTTP::Message is
doing the right thing.

  http://perlmonks.org/?node_id=683833

-Ashley

On May 4, 2008, at 2:21 PM, Daniel McBrearty wrote:


OK, I walked through the code and found out roughly what is going on.
Hard to say where the real source of the bug is (could be at least two
modules) but I have a workaround which I am using (basically just to
remove the croak in HTTP::Message, a bit dirty but probably
harmless).

http://rt.cpan.org/Public/Bug/Display.html?id=34802

I forwarded this to Leon also.

HTH

D

On Sun, May 4, 2008 at 9:30 PM, Daniel McBrearty
[EMAIL PROTECTED] wrote:
yeah, I started setting up cat on a new system yesterday and hit  
this :-(


The salient line seems to be :
HTTP::Message content not bytes at lib/Test/WWW/Mechanize/ 
Catalyst.pm

line 88

I will spend an hour or two on it now, as I hate force installing,  
but

am starting almost from scratch and don't have much intuition yet as
what this is about. Any pointers welcome ...

D





--
Daniel McBrearty
email : danielmcbrearty at gmail.com
http://www.engoi.com
http://danmcb.vox.com
http://danmcb.blogger.com
find me on linkedin and facebook
BTW : 0873928131

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/



___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/