Re: [Catalyst] PageCache and white labelling?

2008-08-18 Thread Matt S Trout
On Mon, Aug 18, 2008 at 12:37:11PM +0800, Martin Ellison wrote: 2008/8/18 Matt S Trout [EMAIL PROTECTED] ...config should be under 'Plugin::PageCache' as I said - that's the standard for plugin config info. If PageCache is still using old style it'd be nice if you could do a first

Re: [Catalyst] PageCache and white labelling?

2008-08-17 Thread Matt S Trout
On Wed, Aug 13, 2008 at 02:59:24PM +0800, Martin Ellison wrote: I put up the patch several days ago; has anyone looked at it? Start a thread on catalyst-dev indicating it's got a patch attached if you want the maintainer to spot it. Also, config should be under 'Plugin::PageCache' as I said -

Re: [Catalyst] PageCache and white labelling?

2008-08-17 Thread Martin Ellison
2008/8/18 Matt S Trout [EMAIL PROTECTED] ...config should be under 'Plugin::PageCache' as I said - that's the standard for plugin config info. If PageCache is still using old style it'd be nice if you could do a first patch switching it across. I'm concerned about doing two things in the

Re: [Catalyst] PageCache and white labelling?

2008-08-13 Thread Martin Ellison
I put up the patch several days ago; has anyone looked at it? 2008/8/9 Martin Ellison [EMAIL PROTECTED] OK, here is some corrected code with some POD: Index: PageCache.pm === --- PageCache.pm(revision 756) +++ PageCache.pm

Re: [Catalyst] PageCache and white labelling?

2008-08-09 Thread Martin Ellison
What about: @@ -316,7 +317,9 @@ # use the key created during the initial dispatch phase return $c-_page_cache_key if ( $c-_page_cache_key ); -my $key = / . $c-req-path; +# override key if required +my $keymaker = $c-config-{page_cache}-{key_maker}; +my $key = $keymaker

Re: [Catalyst] PageCache and white labelling?

2008-08-09 Thread Martin Ellison
OK, here is some corrected code with some POD: Index: PageCache.pm === --- PageCache.pm(revision 756) +++ PageCache.pm(working copy) @@ -316,7 +316,9 @@ # use the key created during the initial dispatch phase return

[Catalyst] PageCache and white labelling?

2008-08-08 Thread Martin Ellison
I get the impression that PageCache cannot discriminate on URL; is that correct? I am trying to 'whitelabel' a site, that is to run several hostnames into the one Catalyst site and then serve somewhat different content based on the URL, giving the appearance of multiple websites. However, it

Re: [Catalyst] PageCache and white labelling?

2008-08-08 Thread Matt S Trout
On Fri, Aug 08, 2008 at 05:08:02PM +0800, Martin Ellison wrote: But PageCache only works off $c-request-path() ie not the hostname. This behaviour is coded in the _get_page_cache_key() subroutine. This means that the PageCache serves up the same page content for all websites, irrespective of

Re: [Catalyst] PageCache and white labelling?

2008-08-08 Thread Martin Ellison
I'm concerned about impacting the performance; this must be high-traffic code. But I'll look into it. 2008/8/8 Matt S Trout [EMAIL PROTECTED] On Fri, Aug 08, 2008 at 05:08:02PM +0800, Martin Ellison wrote: But PageCache only works off $c-request-path() ie not the hostname. This behaviour