Re: [Catalyst] unicode warnings (+ errors C::P::UploadProgress)

2013-06-15 Thread John Napiorkowski
5.90042 should be hitting cpan by now and hopefully resolves these issues. Give 
it a try and let me know.

Bill, this shouldn't break existing apps that didn't use the Unicode plugin and 
where people rolled they're own.  If the latest on cpan breaks your app please 
let us know with details so we can resolve.

To be clear, the only people that have something to do is those that used the 
existing stand alone plugin and relied on the default behavior which is to 
encode UTF8.  At some point they should remove the plugin from the use 
Catalyst ... Line and add the encoding config value since the new default is 
to not encode (so as to not break apps like yours , bill!)

John

Sent from my iPhone

On Jun 14, 2013, at 4:42 PM, Bill Moseley mose...@hank.org wrote:

 On Fri, Jun 14, 2013 at 11:29 AM, John Napiorkowski jjn1...@yahoo.com wrote:
 Yup this is a regression!  We have a patch in HEAD and it should go out 
 later today.  Sorry for the trouble ( but at least I know who's upgrading)
 
 I upgraded yesterday and noticed the same thing in out tests:
 
 [error] Caught exception in engine Can't use string (Can't call method 
 decode on an...) as a HASH ref while strict refs in use at 
 /Users/bill/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Catalyst/Plugin/Unicode/Encoding.pm
  line 101. 
 
 I'll wanted to investigate I have my own code that handles decode/encode and 
 need time to move to the Catalyst code.   Until we can migrate what would you 
 recommend so that we don't have two plugins trying to handle the decoding?
 
 
 I also noticed that UploadProgress got pulled in -- but I don't think we are 
 using that so was a bit surprised by that requirement.
 
 
 -- 
 Bill Moseley
 mose...@hank.org
 ___
 List: Catalyst@lists.scsys.co.uk
 Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
 Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
 Dev site: http://dev.catalyst.perl.org/
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] unicode warnings (+ errors C::P::UploadProgress)

2013-06-14 Thread John Napiorkowski
Yup this is a regression!  We have a patch in HEAD and it should go out later 
today.  Sorry for the trouble ( but at least I know who's upgrading)

John

Sent from my iPhone

On Jun 14, 2013, at 1:18 AM, Brad Bowman l...@bereft.net wrote:

 On 14/06/13 14:39, Alan Humphrey wrote:
 I just upgraded to the latest Catalyst (5.90040). I’m now seeing this warning
 on all pages:
 
 [2013/06/13 09:50:53] [catalyst] [WARN] Can't call method decode on an
 undefined value at
 /home/alanh/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Catalyst/Plugin/Unicode/Encoding.pm
 line 160, DATA line 1003.
 [..]
 
 I'm also getting these warnings with a fresh install of
 Catalyst::Plugin::UploadProgress, and also some errors which
 look related.  Highlights below.
 
 Catalyst-Plugin-UploadProgress-0.06
 $ pmvers Catalyst
 5.90040
 Perl 5.16.3
 
 
 t/01use.t . ok
 [warn] Can't call method decode on an undefined value at 
 /usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm
  line 160.
 ...
 [error] Caught exception in engine Can't use string (Can't call method 
 decode on an...) as a HASH ref while strict refs in use at 
 /usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm
  line 101.
 
 #   Failed test 'Upload ok'
 #   at t/04uploadprogress.t line 48.
 #  got: 'Bad Request'
 # expected: 'ok'
 
 [error] Caught exception in engine Can't use string (Can't call method 
 decode on an...) as a HASH ref while strict refs in use at 
 /usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm
  line 101.
 
 #   Failed test 'Multi-file upload OK'
 #   at t/04uploadprogress.t line 84.
 #  got: 'Bad Request'
 # expected: 'ok'
 
 # Looks like you failed 2 tests of 12.
 t/04uploadprogress.t ..
 Dubious, test returned 2 (wstat 512, 0x200)
 Failed 2/12 subtests
 
 Test Summary Report
 ---
 t/04uploadprogress.t (Wstat: 512 Tests: 12 Failed: 2)
  Failed tests:  2, 8
  Non-zero exit status: 2
 Files=2, Tests=13,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.06 cusr  0.04 
 csys =  1.12 CPU)
 Result: FAIL
 Failed 1/2 test programs. 2/13 subtests failed.
 
 
 ___
 List: Catalyst@lists.scsys.co.uk
 Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
 Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
 Dev site: http://dev.catalyst.perl.org/

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] unicode warnings (+ errors C::P::UploadProgress)

2013-06-14 Thread Bill Moseley
On Fri, Jun 14, 2013 at 11:29 AM, John Napiorkowski jjn1...@yahoo.comwrote:

 Yup this is a regression!  We have a patch in HEAD and it should go out
 later today.  Sorry for the trouble ( but at least I know who's upgrading)


I upgraded yesterday and noticed the same thing in out tests:

[error] Caught exception in engine Can't use string (Can't call method
decode on an...) as a HASH ref while strict refs in use at
/Users/bill/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Catalyst/Plugin/Unicode/Encoding.pm
line 101.

I'll wanted to investigate I have my own code that handles decode/encode
and need time to move to the Catalyst code.   Until we can migrate what
would you recommend so that we don't have two plugins trying to handle the
decoding?


I also noticed that UploadProgress got pulled in -- but I don't think we
are using that so was a bit surprised by that requirement.


-- 
Bill Moseley
mose...@hank.org
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


[Catalyst] unicode warnings

2013-06-13 Thread Alan Humphrey
I just upgraded to the latest Catalyst (5.90040). I’m now seeing this
warning on all pages:

[2013/06/13 09:50:53] [catalyst] [WARN] Can't call method decode on an
undefined value at
/home/alanh/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Catalyst/Plugin/Unicode/Encoding.pm
line 160, DATA line 1003.

Per the upgrade instructions I’ve added a default encoding to my config.jsn:

snip

encoding : UTF-8,

snip



What am I missing?



-  Alan
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] unicode warnings (+ errors C::P::UploadProgress)

2013-06-13 Thread Brad Bowman

On 14/06/13 14:39, Alan Humphrey wrote:

I just upgraded to the latest Catalyst (5.90040). I’m now seeing this warning
on all pages:

[2013/06/13 09:50:53] [catalyst] [WARN] Can't call method decode on an
undefined value at
/home/alanh/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Catalyst/Plugin/Unicode/Encoding.pm
line 160, DATA line 1003.

[..]

I'm also getting these warnings with a fresh install of
Catalyst::Plugin::UploadProgress, and also some errors which
look related.  Highlights below.

Catalyst-Plugin-UploadProgress-0.06
$ pmvers Catalyst
5.90040
Perl 5.16.3


t/01use.t . ok
[warn] Can't call method decode on an undefined value at 
/usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm 
line 160.

...
[error] Caught exception in engine Can't use string (Can't call method 
decode on an...) as a HASH ref while strict refs in use at 
/usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm 
line 101.


#   Failed test 'Upload ok'
#   at t/04uploadprogress.t line 48.
#  got: 'Bad Request'
# expected: 'ok'

[error] Caught exception in engine Can't use string (Can't call method 
decode on an...) as a HASH ref while strict refs in use at 
/usr/local/strategic/perl/lib/site_perl/5.16.3/Catalyst/Plugin/Unicode/Encoding.pm 
line 101.


#   Failed test 'Multi-file upload OK'
#   at t/04uploadprogress.t line 84.
#  got: 'Bad Request'
# expected: 'ok'

# Looks like you failed 2 tests of 12.
t/04uploadprogress.t ..
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/12 subtests

Test Summary Report
---
t/04uploadprogress.t (Wstat: 512 Tests: 12 Failed: 2)
  Failed tests:  2, 8
  Non-zero exit status: 2
Files=2, Tests=13,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.06 cusr  0.04 
csys =  1.12 CPU)

Result: FAIL
Failed 1/2 test programs. 2/13 subtests failed.


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/