Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-07 Thread Andrew Stubbs
On 06/11/12 16:53, Eitan Adler wrote: Perhaps you should get a better version of env? Perhaps I should! I'm running Ubuntu 12.10, so I'm surprised about that. But even if I did there would be many others with the same issue. The followup to this discussion indicates that /bin/sh seems to

Re: [ccache] direct mode design bug

2012-11-07 Thread Joel Rosdahl
Many thanks for the answer! On 5 November 2012 14:53, Andrew Stubbs a...@codesourcery.com wrote: My first reaction to this issue, rightly or wrongly, is that it's more of a documentation issue than a real bug. I mean, it can only occur if two people share a cache, or if the user installs new

Re: [ccache] direct mode design bug

2012-11-07 Thread Joel Rosdahl
On 5 November 2012 16:31, Andrew Stubbs a...@codesourcery.com wrote: Incidentally, you appear to have committed a patch updating the documentation stating that direct mode is off by default, but in the code direct_mode is still true, by default. Yes, I started sketching on disabling it by

Re: [ccache] Fwd: [PATCH] Detect __DATE__ and __TIME__ correctly.

2012-11-07 Thread Joel Rosdahl
On 5 November 2012 13:38, Andrew Stubbs andrew_stu...@mentor.com wrote: That one look right to me. Applied, thanks. I also wrote a bunch of unit tests for check_for_temporal_macros. -- Joel ___ ccache mailing list ccache@lists.samba.org

Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-07 Thread Joel Rosdahl
On 5 November 2012 18:55, Andrew Stubbs a...@codesourcery.com wrote: The test script fails with shells other than bash. At least dash doesn't work. test.sh is intended to work even on Solaris's /bin/sh, which is even more restricted than dash. Current test.sh on master and maint works well

Re: [ccache] direct mode design bug

2012-11-07 Thread Eitan Adler
On 7 November 2012 14:19, Joel Rosdahl j...@rosdahl.net wrote: Hm. Coming to think of it, nothing stops Fedora et al from disabling direct mode by default even if ccache's own default is to enable it. As a package maintainer I would like to discourage this view. Downstream maintainers shouldn't