Re: [ccache] ccache problem with CCACHE_BASEDIR

2012-07-28 Thread Joel Rosdahl
On 27 July 2012 14:33, Joel Rosdahl j...@rosdahl.net wrote: [...] So, the code needs to handle x_realpath returning NULL. Eric, I've now applied your patch with some tweaks in 2df269a3121889ebcdfa5d98dfb4d675f690e039 (see

Re: [ccache] ccache problem with CCACHE_BASEDIR

2012-07-27 Thread Joel Rosdahl
Hi, It seems you forgot to make cwd_canonicalized static? Currently, it has no effect. Also, the test suite crashes with your patch. I recommend running the test suite during development even for minor patches (and for bonus points: add new tests for the new functionality :-)). The crash happens

Re: [ccache] ccache problem with CCACHE_BASEDIR

2012-07-19 Thread Eric Blau
On 2012-06-11 07:54, Eric Blau wrote: On 2012-06-10 16:09, Joel Rosdahl wrote: My suggestion is that get_relative_path essentially should stay the same and continue to assume that the paths are well-formed and canonical. make_relative_path (the only caller of get_relative_path) should

Re: [ccache] ccache problem with CCACHE_BASEDIR

2012-06-11 Thread Eric Blau
On 2012-06-10 16:09, Joel Rosdahl wrote: My suggestion is that get_relative_path essentially should stay the same and continue to assume that the paths are well-formed and canonical. make_relative_path (the only caller of get_relative_path) should canonicalize current_working_dir and path by

[ccache] ccache problem with CCACHE_BASEDIR

2012-06-05 Thread Blau, Eric
Hi folks, I've been trying to use ccache with the CCACHE_BASEDIR option so that my fellow team members can take advantage of compiles that have already been done by each other from a different directory. I'm seeing ccache do inappropriate replacements of absolute paths with relative paths.