Re: [ccache] ccache interrupt handling bug

2015-08-30 Thread Nadav Har'El
On Sat, Aug 29, 2015 at 8:01 PM, Joel Rosdahl j...@rosdahl.net wrote:

 On 20 August 2015 at 21:04, Joel Rosdahl j...@rosdahl.net wrote:

 I will not have time to work on improving the signal handler until next
 week at the earliest.


 I've now had a look at improving the signal handler. It would be
 appreciated if somebody wants to review it:
 https://git.samba.org/?p=ccache.git;a=commitdiff;h=737c96fabeab9d66407758b848468aa49190c946


Hi,

Looking at this code, I don't see any obvious holes and it all seems
correct.

One thing you should perhaps consider is whether this change (using
sigaction, signal sets, instead of the antique signal(), etc.) might break
compilation on some antique UNIX machines or on MS-Windows (!?) or
something. But I doubt any present-day system actually lacks sigaction()
and friends, so I think your code is good.




-- 
Nadav Har'El
n...@cloudius-systems.com
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache


Re: [ccache] ccache interrupt handling bug

2015-08-30 Thread Tom Lane
Nadav Har'El n...@cloudius-systems.com writes:
 One thing you should perhaps consider is whether this change (using
 sigaction, signal sets, instead of the antique signal(), etc.) might break
 compilation on some antique UNIX machines or on MS-Windows (!?) or
 something. But I doubt any present-day system actually lacks sigaction()
 and friends, so I think your code is good.

Windows is definitely a risk factor here: AFAIK they don't provide a
decent emulation of the POSIX signal functions.  However, they don't
have the BSD ones either, so I assume ccache is already covering
Windows specially.

As for the antique UNIX angle, I can offer a data point: Postgres
still nominally carries support for the pre-POSIX signal API, but
AFAICT that code isn't being used on any platform still in use.
*All* of the active non-Windows members of our buildfarm report that
their configure test for POSIX signals succeeds.  And there are some
pretty darn old systems in there:
http://buildfarm.postgresql.org/cgi-bin/show_status.pl

regards, tom lane

___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache