Hello,
please review and push the attached patch, which adds Clang plugins to the
hash, similarly as is already done with GCC plugins.
--
Lubos Lunak
l.lu...@suse.cz
From 11b35610cf97b1540dc883b03e7ce059735bd04c Mon Sep 17 00:00:00 2001
From: Lubos Lunak l.lu...@suse.cz
Date: Thu, 26 Jul
On 30 July 2012 19:03, Lubos Lunak l.lu...@suse.cz wrote:
please review and push the attached patch, which adds Clang plugins to the
hash, similarly as is already done with GCC plugins.
Thanks, applied.
-- Joel
___
ccache mailing list
-Original Message-
From: joel.rosd...@gmail.com [mailto:joel.rosd...@gmail.com] On Behalf Of
Joel Rosdahl
+ file_args = args_init_from_string(argdata);
Isn't args_init_from_string too simplistic for parsing the contents?
Oof, yeah you're right. It seems that
From: Boie, Andrew P andrew.p.b...@intel.com
These indicate to the compiler that additional command line options
should be read from a text file. If encountered, read the file,
tokenize any arguments, and if any are found, do an in-place replacement
of the '@' parameter with the arguments within
-Original Message-
From: Jürgen Buchmüller [mailto:pullm...@t-online.de]
Sent: Monday, July 30, 2012 4:46 PM
To: Boie, Andrew P
Cc: ccache@lists.samba.org
Subject: Re: [ccache] [PATCH v3] add support for '@' parameters
Am Montag, den 30.07.2012, 16:05 -0700 schrieb Andrew Boie:
Am Montag, den 30.07.2012, 16:05 -0700 schrieb Andrew Boie:
[..snip..]
+ /* Trivial case; replace with 1 element */
+ dest-argv[index] = x_strdup(src-argv[0]);
[..snap..]
Shouldn't dest-argv[index] be free()d before overwriting it?
+ /* Copy the new arguments into
From: Boie, Andrew P andrew.p.b...@intel.com
These indicate to the compiler that additional command line options
should be read from a text file. If encountered, read the file,
tokenize any arguments, and if any are found, do an in-place replacement
of the '@' parameter with the arguments within
Changes from patch set 3:
- args_insert() now consumes the arguments to be inserted, the caller doesn't
need to subsequently free it. Avoids some strdups
- test cases and args_insert use in ccache.c updated to reflect new semantics
Andrew
-Original Message-
From: Boie, Andrew P
