Re: [ccache] Suggested patch to add local strtok_r for systems lacking it

2012-05-13 Thread Joel Rosdahl
Hi, On 12 April 2012 08:32, Jürgen Buchmüller pullm...@t-online.de wrote: here's a suggested patch for config.h.in and util.c to add a local implementation of strtok_r for systems that don't have it (e.g. mingw32 plus libgw32c). A lot of Windows build related work has already been done in the

Re: [ccache] Suggested patch to add local strtok_r for systems lacking it

2012-04-12 Thread Martin Pool
Thanks for the patch. I guess the definition ought to be guarded by HAVE_STRTOK_R, not _WIN32. Perhaps you also need to update configure.in to check for it? m ___ ccache mailing list ccache@lists.samba.org

Re: [ccache] Suggested patch to add local strtok_r for systems lacking it

2012-04-12 Thread Jürgen Buchmüller
Am Donnerstag, den 12.04.2012, 18:54 +1000 schrieb Martin Pool: Thanks for the patch. I guess the definition ought to be guarded by HAVE_STRTOK_R, not _WIN32. Of course! I should have looked through it once more before submission. Perhaps you also need to update configure.in to check for

Re: [ccache] Suggested patch to add local strtok_r for systems lacking it

2012-04-12 Thread Mike Frysinger
On Thursday 12 April 2012 02:32:39 Jürgen Buchmüller wrote: here's a suggested patch for config.h.in and util.c to add a local implementation of strtok_r for systems that don't have it (e.g. mingw32 plus libgw32c). sounds like we should just integrate gnulib instead of open coding all of our