Re: [ccache] [PATCH v3] add support for '@' parameters

2012-07-30 Thread Boie, Andrew P
-Original Message- From: Jürgen Buchmüller [mailto:pullm...@t-online.de] Sent: Monday, July 30, 2012 4:46 PM To: Boie, Andrew P Cc: ccache@lists.samba.org Subject: Re: [ccache] [PATCH v3] add support for '@' parameters Am Montag, den 30.07.2012, 16:05 -0700 schrieb Andrew Boie

Re: [ccache] [PATCH v3] add support for '@' parameters

2012-07-30 Thread Jürgen Buchmüller
Am Montag, den 30.07.2012, 16:05 -0700 schrieb Andrew Boie: [..snip..] + /* Trivial case; replace with 1 element */ + dest-argv[index] = x_strdup(src-argv[0]); [..snap..] Shouldn't dest-argv[index] be free()d before overwriting it? + /* Copy the new arguments into