Re: [ccache] Support for color diagnostics

2014-06-26 Thread Lubos Lunak
On Saturday 14 of June 2014, Joel Rosdahl wrote: > Hi Lubos, > > Sorry about the ping delay. I've now looked at your patch and it looks > promising. ... > I suggest passing the argument list as an argument to the compiler_is_* > functions instead of relying on global variables. > > When extracting

Re: [ccache] Support for color diagnostics

2014-06-26 Thread Paul Smith
On Thu, 2014-06-26 at 18:44 +0200, Lubos Lunak wrote: > Caveats: > - Compiles with and without colors are considered different from each > other (so they are "duplicated"). This doesn't seem ideal, does it? If I'm understanding this correctly won't this cause rebuilds based on whether you're redi

Re: [ccache] Support for color diagnostics

2014-06-26 Thread Lubos Lunak
On Thursday 26 of June 2014, Paul Smith wrote: > On Thu, 2014-06-26 at 18:44 +0200, Lubos Lunak wrote: > > Caveats: > > - Compiles with and without colors are considered different from each > > other (so they are "duplicated"). > > This doesn't seem ideal, does it? No, it doesn't seem ideal. It d