Re: [ccache] PATCH: Fix version.c for older gits

2010-09-26 Thread Joel Rosdahl
On 2010-09-24 20:46, Wilson Snyder wrote: > > "git describe --dirty" is a very recent addition. I would > suggest the following so that the version works properly on > older versions. Thanks, applied. -- Joel ___ ccache mailing list ccache@lists.samba

Re: [ccache] PATCH: Fix version.c for older gits

2010-09-24 Thread Mike Frysinger
On Fri, Sep 24, 2010 at 14:46, Wilson Snyder wrote: > -    $(shell (git describe --dirty 2>/dev/null || echo vunknown) \ > +    $(shell (git describe --dirty 2>/dev/null || git describe 2>/dev/null || > echo vunknown) \ probably better to move the stderr outside of the subshell: $(shell (g

[ccache] PATCH: Fix version.c for older gits

2010-09-24 Thread Wilson Snyder
"git describe --dirty" is a very recent addition. I would suggest the following so that the version works properly on older versions. Thanks! diff --git a/dev.mk.in b/dev.mk.in index d4dc1f7..1a7c00b 100644 --- a/dev.mk.in +++ b/dev.mk.in @@ -8,7 +8,7 @@ XSLTPROC = xsltproc MANPAGE_XSL = /etc/