Re: [ccache] base_dir and -Xclang option - bug or incompleteness?

2016-03-25 Thread Joel Rosdahl
On 23 March 2016 at 17:56, Michael Kolomeytsev <
michael.kolomeyt...@gmail.com> wrote:
> I looked into the ccache source code
> https://github.com/jrosdahl/ccache/blob/master/ccache.c#L1696 - that
> special Xlang options  processing is exactly what I need. But it doesn't
> work 'cause "i+=3" is forgotten before the "continue"?

Yes, indeed looks so. I've applied your pull request, thanks!

-- Joel
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache


[ccache] base_dir and -Xclang option - bug or incompleteness?

2016-03-23 Thread Michael Kolomeytsev
Hi,
I have two copies of the same project and use base_dir option to share
cache between them.
And everything works fine until there are such options in command line:
... -Xclang -load -Xclang /project1/path/libFindBadConstructs.so ...
The path to the libFindBadConstructs.so is slightly different:
/project1/path/libFindBadConstructs.so or
/project2/path/libFindBadConstructs.so.
And currently ccache generates two different hashes/manifests and there is
no cache sharing unfortunately :(

I looked into the ccache source code.
https://github.com/jrosdahl/ccache/blob/master/ccache.c#L1696 - that
special Xlang options  processing is exactly what I need. But it doesn't
work 'cause "i+=3" is forgotten before the "continue"?

Or should we add hashes for that options but "make_relative_path" for a
path to a plugin?
It seems replacing TAKE_ARG with TAKE_PATH in compopt.c for "Xclang" is
enough.
https://github.com/jrosdahl/ccache/blob/master/compopt.c#L53

I can fix it if someone will say what fix is better.
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache