Re: [ccache] base_dir and symbolic links

2018-01-02 Thread Andreas Wettstein via ccache
Hello Joel, > https://www.mail-archive.com/ccache@lists.samba.org/msg00802.html Thank you. It is trickier than I thought. > ccache has a test suite and it fails like this with your patch: Sorry, I missed the test directory. Attached is a modified patch, which fixes this issue and includes

Re: [ccache] base_dir and symbolic links

2017-12-30 Thread Joel Rosdahl via ccache
Hi Andreas, > [...] I understand that it makes > sense to make the current working directory canonic, but I do not > see why this done for the path given to `make_relative_path`. Is > it really necessary? Some background can be found in this mail thread:

Re: [ccache] base_dir and symbolic links

2017-09-17 Thread Andreas Wettstein via ccache
> Seems like a pretty niche use case, but if you can come up with a > patch that doesn't break too much of current behaviour - why not. Thank you for considering it. A patch is in the attachment. > Worst case, it could be an option (that defaulted to false) ? I would not consider this the

Re: [ccache] base_dir and symbolic links

2017-09-16 Thread Anders Björklund via ccache
Andreas Wettstein wrote: > In function `make_relative_path` (file `ccache.c`), the given > path is made "canonic" before it is converted to a path relative > to the current working directory. In particular, "canonic" means > that symbolic links are removed. I understand that it makes > sense to

[ccache] base_dir and symbolic links

2017-09-13 Thread Andreas Wettstein via ccache
In function `make_relative_path` (file `ccache.c`), the given path is made "canonic" before it is converted to a path relative to the current working directory. In particular, "canonic" means that symbolic links are removed. I understand that it makes sense to make the current working directory