Re: [ccache] PATCH: Fix version.c for older gits

2010-09-26 Thread Joel Rosdahl
On 2010-09-24 20:46, Wilson Snyder wrote:
 
 git describe --dirty is a very recent addition.  I would
 suggest the following so that the version works properly on
 older versions.

Thanks, applied.

-- Joel
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache


Re: [ccache] PATCH: Fix version.c for older gits

2010-09-24 Thread Mike Frysinger
On Fri, Sep 24, 2010 at 14:46, Wilson Snyder wrote:
 -    $(shell (git describe --dirty 2/dev/null || echo vunknown) \
 +    $(shell (git describe --dirty 2/dev/null || git describe 2/dev/null || 
 echo vunknown) \

probably better to move the stderr outside of the subshell:
   $(shell (git describe --dirty || git describe || echo vunknown)
2/dev/null \
-mike
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache