Re: [ccache] PATCH: Look at include files' mtimes

2013-06-03 Thread Justin Lebar
FWIW I've been using ccache with mtime checking for the past few weeks and I haven't noticed any problems. That is a pretty low bar, I admit, but it's something. :) On Sun, Mar 3, 2013 at 3:54 PM, Joel Rosdahl j...@rosdahl.net wrote: Hi Justin, I've resurrected these patches to look at

Re: [ccache] PATCH: Look at include files' mtimes

2013-03-03 Thread Joel Rosdahl
Hi Justin, I've resurrected these patches to look at files' mtimes and ctimes. [...] I just found out that I forgot to have a look at your patches. Sorry about the delay. I seem fine, so I've applied them. I did need to fix the unit tests since they failed, though. Please have a look and see

Re: [ccache] PATCH: Look at include files' mtimes

2012-12-24 Thread Justin Lebar
Hi, all. I've resurrected these patches to look at files' mtimes and ctimes. Hopefully the three patches here (with their commit messages) don't need further explanation. Note that the second patch here increases safety for everyone, not just those who choose to have mtime matching on. These

Re: [ccache] PATCH: Look at include files' mtimes

2012-05-28 Thread Wilson Snyder
I can't say I'm particularly interested in supporting two manifest versions simultaneously I agree that supporting only the latest should be enough. Coming to think of it, perhaps it would be a good idea to include the manifest version in the manifest hash so that ccache versions using

Re: [ccache] PATCH: Look at include files' mtimes

2012-05-28 Thread Wilson Snyder
Allowing multiple versions to co-reside and not trash each other's result would be useful. =A0Presently I need redefine CCACHE_DIR for each version to avoid overlap, which is annoying. [...] From the top of my head, the issues I'm aware of regarding different ccache versions accessing the

Re: [ccache] PATCH: Look at include files' mtimes

2012-05-23 Thread Joel Rosdahl
On 22 May 2012 04:00, Justin Lebar justin.le...@gmail.com wrote: I can't say I'm particularly interested in supporting two manifest versions simultaneously I agree that supporting only the latest should be enough. Coming to think of it, perhaps it would be a good idea to include the manifest

Re: [ccache] PATCH: Look at include files' mtimes

2012-05-22 Thread Martin Pool
On 22 May 2012 12:00, Justin Lebar justin.le...@gmail.com wrote: I've been burned by mtime only checking before as (excluding some recent file systems) mtime has a resolution only down to one second. I tried to address this in the patch, although come to think of it, I did it wrong. The

Re: [ccache] PATCH: Look at include files' mtimes

2012-05-22 Thread Justin Lebar
Better to do 2 seconds, since FAT (and maybe some other Windows related setups) has only a 2-second resolution. The other thing you can do is, on Unix, use the latest of ctime and mtime, which should catch cases where the mtime gets reset. Thanks for the tips! I'm happy to update the patch,