Re: [ccache] ccache interrupt handling bug

2015-08-30 Thread Nadav Har'El
On Sat, Aug 29, 2015 at 8:01 PM, Joel Rosdahl j...@rosdahl.net wrote: On 20 August 2015 at 21:04, Joel Rosdahl j...@rosdahl.net wrote: I will not have time to work on improving the signal handler until next week at the earliest. I've now had a look at improving the signal handler. It would

Re: [ccache] ccache interrupt handling bug

2015-08-30 Thread Tom Lane
Nadav Har'El n...@cloudius-systems.com writes: One thing you should perhaps consider is whether this change (using sigaction, signal sets, instead of the antique signal(), etc.) might break compilation on some antique UNIX machines or on MS-Windows (!?) or something. But I doubt any

Re: [ccache] ccache interrupt handling bug

2015-08-29 Thread Joel Rosdahl
On 20 August 2015 at 21:04, Joel Rosdahl j...@rosdahl.net wrote: I will not have time to work on improving the signal handler until next week at the earliest. I've now had a look at improving the signal handler. It would be appreciated if somebody wants to review it:

Re: [ccache] ccache interrupt handling bug

2015-08-20 Thread Joel Rosdahl
On 19 August 2015 at 15:45, Mike Frysinger vap...@gentoo.org wrote: this wouldn't solve things entirely. calling _exit(1) is fundamentally wrong. here's a pretty good page giving a rundown: [...] Interesting, thank you. And thanks to Nadav and Eitan as well for good input. I will not have

Re: [ccache] ccache interrupt handling bug

2015-08-16 Thread Tom Lane
Nadav Har'El n...@cloudius-systems.com writes: First of all, thanks. This indeed fixes the bug, and is exactly the first patch I tried to fix it this problem. I want to explain, though, why I ended up sending a different patch for this problem - a 4-line patch instead of this one-liner. The

Re: [ccache] ccache interrupt handling bug

2015-08-16 Thread Tom Lane
Nadav Har'El n...@cloudius-systems.com writes: On Mon, Aug 17, 2015 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: * make launches ccache gcc -o test.o test.c * user types control-C * ccache receives SIGINT and exits * make does unlink(test.o) to clean up after failed compile step, which it

Re: [ccache] ccache interrupt handling bug

2015-08-16 Thread Nadav Har'El
On Sun, Aug 9, 2015 at 11:23 PM, Joel Rosdahl j...@rosdahl.net wrote: Hi Nadav, (Sorry for the delayed reply.) Hi, I found a bug in ccache, which makes it impossible to correctly interrupt a compilation with a control-C (I tried this on Linux). [...] Thanks for the bug report and

Re: [ccache] ccache interrupt handling bug

2015-08-16 Thread Nadav Har'El
On Mon, Aug 17, 2015 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: * make launches ccache gcc -o test.o test.c * user types control-C * ccache receives SIGINT and exits * make does unlink(test.o) to clean up after failed compile step, which it thinks is done * gcc creates test.o

Re: [ccache] ccache interrupt handling bug

2015-08-09 Thread Joel Rosdahl
Hi Nadav, (Sorry for the delayed reply.) Hi, I found a bug in ccache, which makes it impossible to correctly interrupt a compilation with a control-C (I tried this on Linux). [...] Thanks for the bug report and analysis. This will be fixed in ccache 3.2.3. Regards, -- Joel