Re: [ccan] [PATCH 0/5] altstack: cleanups

2016-06-03 Thread Dan Good
David, thank you for improving the code. I'm traveling for the next week with only an ipad. I'd like to ask your thoughts on a topic or two, but typing on this is grueling. I hope to try for a longer reply later. Thanks again. -Dan On Fri, Jun 3, 2016 at 4:40 AM David Gibson

Re: [ccan] [PATCH 5/5] altstack: Don't log internal calls in test cases

2016-06-11 Thread Dan Good
Hairy macros? From the author of the cppmagic module, I shall take that as a compliment. The purpose of the setcall macro and related checks is ensure the correctness of the error path, i.e. if setrlimit ran before a failure, it must run again to undo the first; if mmap ran before a failure,

Re: [ccan] [PATCH 4/5] altstack: Don't use 0 pointer literals

2016-06-11 Thread Dan Good
Hi David, I'm back home in front of a real keyboard, and want to follow up with you about your patches. I must admit that my usual practice is to use NULL, and not 0. Around the time I wrote altstack I had recently read Jen Gustedt's book, Modern C. In it, he makes the point that NULL hides

Re: [ccan] [PATCH 4/5] altstack: Don't use 0 pointer literals

2016-06-16 Thread Dan Good
Thank you, both. I'll return to the fold and use NULL, as seems right and proper. On Thu, Jun 16, 2016 at 7:12 AM David Gibson <da...@gibson.dropbear.id.au> wrote: > On Tue, Jun 14, 2016 at 01:45:10PM +0930, Paul 'Rusty' Russell wrote: > > Dan Good <d...@dancancode.com> w

Re: [ccan] [PATCH 5/5] altstack: Don't log internal calls in test cases

2016-06-16 Thread Dan Good
Very well, I've applied your patches as provided (except I dropped the trailing underscore from state.rsp_save). On Thu, Jun 16, 2016 at 7:12 AM David Gibson <da...@gibson.dropbear.id.au> wrote: > On Sun, Jun 12, 2016 at 02:10:18AM +0000, Dan Good wrote: > > Hairy macros?

Re: [ccan] git error on push

2016-02-10 Thread Dan Good
Don't I feel silly. Thank you. All better now. On Wed, Feb 10, 2016 at 8:16 PM David Gibson <da...@gibson.dropbear.id.au> wrote: > On Wed, Feb 10, 2016 at 07:15:02PM +0000, Dan Good wrote: > > Hi, I'm trying to push the stack alignment patch to the repo, but no joy: > > &