Re: [ccan] [PATCH 6/9] configurator: Print test source without cat

2016-09-19 Thread David Gibson
On Sun, Sep 18, 2016 at 06:52:03PM -0600, Kevin Locke wrote: > Windows does not provide cat. Instead, copy the test source to stdout > using the file stream to which it was written. > > Signed-off-by: Kevin Locke > --- > tools/configurator/configurator.c | 28

Re: [ccan] [PATCH 5/9] configurator: Mark non-Windows tests MAY_NOT_COMPILE

2016-09-19 Thread David Gibson
On Sun, Sep 18, 2016 at 06:52:02PM -0600, Kevin Locke wrote: > Several of the EXECUTABLE tests depend on headers not available on > Windows. Mark these tests MAY_NOT_COMPILE to handle this. > > Signed-off-by: Kevin Locke Reviewed-by: David Gibson

Re: [ccan] [PATCH 3/9] configurator: Inline err.h functions from musl libc

2016-09-19 Thread David Gibson
On Sun, Sep 18, 2016 at 06:52:00PM -0600, Kevin Locke wrote: > Since we can't use HAVE_ERR_H in configurator, provide a definition for > the err.h functions used. The version provided is the one from musl > libc, since it is concise and shares the MIT License with configurator. > >

Re: [ccan] [PATCH 1/9] configurator: Replace unlink with remove

2016-09-19 Thread David Gibson
On Sun, Sep 18, 2016 at 06:51:58PM -0600, Kevin Locke wrote: > Although Windows provides unlink, using it adds complication due to the > lack of unistd.h which must be included to define the function on POSIX > systems. Instead, use remove, which C89 requires to be in stdio.h. > > Signed-off-by: