Re: [ccan] [PATCH 2/9] configurator: Reimplement run using popen

2016-09-20 Thread Kevin Locke
On 09/19/2016 11:00 PM, David Gibson wrote: > On Sun, Sep 18, 2016 at 06:51:59PM -0600, Kevin Locke wrote: >> Rather than using fork+pipe+system+waitpid, most of which are only >> available on POSIX-like systems, use popen which is also available on >> Windows (under the name _popen). > > Concept

Re: [ccan] [PATCH 8/9] configurator: Pass output cflag to configurator

2016-09-20 Thread Kevin Locke
On 09/19/2016 11:23 PM, David Gibson wrote: On Sun, Sep 18, 2016 at 06:52:05PM -0600, Kevin Locke wrote: Unfortunately, not all compilers support -o as a command-line option for specifying the output file. Visual Studio cl.exe issues warning D9035 when -o is given, which is detected as a

Re: [ccan] [PATCH 0/9] configurator: Support for Windows and MSVC

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 12:21:25AM -0600, Kevin Locke wrote: > Hi David, > > Thank you for taking the time to review these patches, especially for a > platform that you don't have a strong stake in. I really appreciate it. > > On 09/19/2016 10:48 PM, David Gibson wrote: > > On Sun, Sep 18, 2016

Re: [ccan] [PATCH 2/9] configurator: Reimplement run using popen

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 12:22:41AM -0600, Kevin Locke wrote: > On 09/19/2016 11:00 PM, David Gibson wrote: > > On Sun, Sep 18, 2016 at 06:51:59PM -0600, Kevin Locke wrote: > >> Rather than using fork+pipe+system+waitpid, most of which are only > >> available on POSIX-like systems, use popen which

Re: [ccan] [PATCH 8/9] configurator: Pass output cflag to configurator

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 12:22:47AM -0600, Kevin Locke wrote: > On 09/19/2016 11:23 PM, David Gibson wrote: > > On Sun, Sep 18, 2016 at 06:52:05PM -0600, Kevin Locke wrote: > > > Unfortunately, not all compilers support -o as a command-line option for > > > specifying the output file. Visual

Re: [ccan] [PATCH 0/9] configurator: Support for Windows and MSVC

2016-09-20 Thread Daniel Burke
I do have a bit of experience with windows/linux C code interop, and while Visual C++ tends to be somewhat... unpredictable (It's getting much better than it used to be), I can tell you that... x86_64-w64-mingw32-gcc will output binaries that will happily run on windows, so long as you're using