Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted (with appropriate reverting commits)

2018-08-08 Thread Jon Trulson
This is much better, but not quite complete. The databases/CDE-RUN.udb changes are still missing. As a result, they build now, but the binaries are never installed... This should have been part of one of the reverts you did (revert of 7f70748d), however, it seems those changes did not make it

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Jon Trulson
On 07/31/2018 07:31 PM, Chase wrote: Ahh now I see, thats what I did the first time, so I need to commit the reverts as well? Because I did revert the commits on my side. Everything works without errors, just compiler warnings. When you do a revert, it will add a new commit that undoes the c

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Chase via cdesktopenv-devel
Ahh now I see, thats what I did the first time, so I need to commit the reverts as well? Because I did revert the commits on my side. Everything works without errors, just compiler warnings. Thank you for your time, -Chase ‐‐‐ Original Message ‐‐‐ On July 31, 2018 8:28 PM, Jon Trulson

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Jon Trulson
I think Matthew explained it pretty well. You might do some reading up on git, and typical git workflows - there's tons of docs out there. But essentially: You create a branch from current master, revert the 2(?) previous commits that removed dtudcfont* programs (look at the "git revert" com

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Matthew R. Trower
Chase writes: > I guess I'm just having trouble understanding what I must do > differently, does my patch simply need to be rebased and the commits > deleting dtudcfonted can be reversed on your end, or do I need to > manually readd all the previous files by hand from a previous version > and rep

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Chase via cdesktopenv-devel
I guess I'm just having trouble understanding what I must do differently, does my patch simply need to be rebased and the commits deleting dtudcfonted can be reversed on your end, or do I need to manually readd all the previous files by hand from a previous version and repatch? Because one solut

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-31 Thread Jon Trulson
Yes, what Matthew said below is the way to go - you don't have to throw everything away and start over from scratch -- though you will need to start a new, clean branch from master and "construct and maintain" it properly as Matthew outlines below. It is important to rebase from time to time a

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-30 Thread Matthew R. Trower
Chase via cdesktopenv-devel writes: > To be honest, I don't know how I would go about doing this, help would > be appreciated. Is it at least pheasable to revert the previous > commits and apply this one? I put a lot of work into it. My git > workflow consists of master and then a custom branch w

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-30 Thread Chase via cdesktopenv-devel
To be honest, I don't know how I would go about doing this, help would be appreciated. Is it at least pheasable to revert the previous commits and apply this one? I put a lot of work into it. My git workflow consists of master and then a custom branch where I reverted the previous commits and pa

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-29 Thread Jon Trulson
That's not how this works... :) If you are going to support this, then you need to essentially re-add it as a new component... And it needs to be complete and functional at that time, and apply to whatever branch (master or cde-next) you are targeting... You can go back to an earlier versio

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-29 Thread Chase via cdesktopenv-devel
The patch requires the disabling and deleting commits to be reversed. Thank you for your time, -Chase ‐‐‐ Original Message ‐‐‐ On July 29, 2018 5:50 PM, Jon Trulson wrote: > I'm not sure what I'm supposed to do with this. These have been removed > from master (via cde-next) some weeks

Re: [cdesktopenv-devel] [PATCH] Refactor and reimplement dtudcfonted

2018-07-29 Thread Jon Trulson
I'm not sure what I'm supposed to do with this. These have been removed from master (via cde-next) some weeks ago, and would not build anymore even with this patch... In addition, you mention yourself that it's not done, so... Why did you submit it? :) Perhaps you need to occasionally rebase