Re: [ceph-devel] [PATCH] fs/ceph: Move a dereference below a NULL test

2009-11-21 Thread Sage Weil
On Sat, 21 Nov 2009, Julia Lawall wrote: > From: Julia Lawall > > If the NULL test is necessary, then the dereference should be moved below > the NULL test. I've applied this (and the previous patch) to the ceph tree. Thanks! sage > > The semantic patch that makes this change is as follow

Re: [ceph-devel] question about fs/ceph/snap.c

2009-11-21 Thread Sage Weil
On Sat, 21 Nov 2009, Julia Lawall wrote: > The file fs/ceph/snap.c contains four calls to ceph_lookup_snap_realm, all > of which test the returned value first with IS_ERR and then by checking > for a NULL pointer. But the definition of ceph_lookup_snap_realm contains > a dereference of its argu

[ceph-devel] question about fs/ceph/snap.c

2009-11-21 Thread Julia Lawall
The file fs/ceph/snap.c contains four calls to ceph_lookup_snap_realm, all of which test the returned value first with IS_ERR and then by checking for a NULL pointer. But the definition of ceph_lookup_snap_realm contains a dereference of its argument if it is not NULL, which suggests that an ER

Re: [ceph-devel] help regarding ceph test cluster

2009-11-21 Thread Gregory Farnum
Can you give us more details? What does your ceph.conf look like? What's the exact error? -Greg On Fri, Nov 20, 2009 at 10:56 AM, Amarnath BS wrote: > > hello every one, > I have tried to setup ceph using three nodes.one > node acting as mds+client and other two as OSD's

[ceph-devel] [PATCH] fs/ceph: Move a dereference below a NULL test

2009-11-21 Thread Julia Lawall
From: Julia Lawall If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/). // @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when !=

[ceph-devel] help regarding ceph test cluster

2009-11-21 Thread Amarnath BS
hello every one, I have tried to setup ceph using three nodes.one node acting as mds+client and other two as OSD's,but when try to run csyn at client side i get an error denoting client as client? .I am unable to understand why the client is not getting recognized.

Re: [ceph-devel] trouble with the kernel client git repo

2009-11-21 Thread Noah Watkins
Give one of these a shot: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git http://www.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git http://git.kernel.org/smart/pub/scm/linux/kernel/git/sage/ceph-client.git Best to use the Git protocol: $ git clone git://git.k

[ceph-devel] [PATCH 8/8] fs/ceph: introduce missing kfree

2009-11-21 Thread Julia Lawall
From: Julia Lawall Error handling code following a kmalloc should free the allocated data. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expressi

[ceph-devel] trouble with the kernel client git repo

2009-11-21 Thread Tim Cullen
I am doing something wrong here or is there something wrong with the kernel client git repo? [r...@rna13 tmp]# git clone http://git.kernel.org/?p=linux/kernel/git/sage/ceph-client.git Initialized empty Git repository in /root/src/tmp/ceph-client/.git/ fatal: http://git.kernel.org/?p=linux/kernel