Hi Sage,
My bad, indeed. I'll resubmit a patch.
Cheers
On 02/17/2013 03:11 AM, Sage Weil wrote:
On Sun, 17 Feb 2013, Loic Dachary wrote:
When running
bufferptr a(A, 1);
bufferptr ab(AB, 2);
a.cmp(ab);
it returned zero because cmp only compared up to the length of the
smallest
On Thu, Jan 24, 2013 at 10:01 PM, Sage Weil s...@inktank.com wrote:
On Thu, 24 Jan 2013, Andrey Korolyov wrote:
On Thu, Jan 24, 2013 at 8:39 AM, Sage Weil s...@inktank.com wrote:
On Thu, 24 Jan 2013, Andrey Korolyov wrote:
On Thu, Jan 24, 2013 at 12:59 AM, Jens Kristian S?gaard
+1
--
Regards,
Sébastien Han.
On Sat, Feb 16, 2013 at 10:09 AM, Wido den Hollander w...@42on.com wrote:
On 02/16/2013 08:09 AM, Andrey Korolyov wrote:
Can anyone who hit this bug please confirm that your system contains libc
2.15+?
I've seen this with 0.56.2 as well on Ubuntu 12.04.
Applied, thanks!
I left this in master since the only current caller I see is in the omap
scrubbing code. We may want to backport it soonish, though.
sage
On Sun, 17 Feb 2013, Loic Dachary wrote:
When running
bufferptr a(A, 1);
bufferptr ab(AB, 2);
a.cmp(ab);
it returned zero
On Sun, 17 Feb 2013, Andrey Korolyov wrote:
On Thu, Jan 24, 2013 at 10:01 PM, Sage Weil s...@inktank.com wrote:
On Thu, 24 Jan 2013, Andrey Korolyov wrote:
On Thu, Jan 24, 2013 at 8:39 AM, Sage Weil s...@inktank.com wrote:
On Thu, 24 Jan 2013, Andrey Korolyov wrote:
On Thu, Jan 24, 2013
Implement unit tests covering most lines of code ( 92% ) and all
methods as show by the output of make check-coverage :
http://dachary.org/wp-uploads/2013/03/ceph-lcov/ .
The following static constructors are implemented by opaque classes
defined in buffer.cc ( buffer::raw_char,
Hi Loic,
I merged this in, which two small changes:
- the malloc ULLONG_MAX tests were succeeding and eating RAM on my box;
commented them out.
- the BIG_SZ buffer on teh stack was segfaulting; put it on the heap.
Otherwise, looks great! I'm very pleased to have test coverage on this
code.
