[PATCH] osdc: re-calculate truncate_size for strip objects

2013-06-20 Thread Yan, Zheng
From: Yan, Zheng zheng.z@intel.com Fixes #5380 Signed-off-by: Yan, Zheng zheng.z@intel.com --- src/client/Client.cc | 8 src/librbd/ImageCtx.cc | 4 ++-- src/librbd/internal.cc | 10 +- src/osd/osd_types.h | 6 -- src/osdc/Filer.cc| 2 +-

rbd: assertion failure in rbd_img_obj_callback()

2013-06-20 Thread Andreas Bluemle
Hi, when working on a large rbd image, I am hitting an assertion failure in rbd kernel module; the assertion is in rbd_img_obj_callback() rbd_assert(img_request != NULL); The test is a sequential write on an rbd image, format 1. The size of the image is 1 TByte, order is 22 (i.e.

Re: mon crash

2013-06-20 Thread Joao Eduardo Luis
On 06/20/2013 12:31 AM, James Harper wrote: On Wed, 19 Jun 2013, James Harper wrote: Every time I start up one of my mons it crashes. Two others are running but there seems to be long delays (=several seconds) when doing mon status (maybe this is the behaviour when one mon is down?) The tail

[PATCH] rgw: Added an encoder for time_t to fix compilation

2013-06-20 Thread christophe courtaut
On the rgw-wip-geo-2 branch, the encode decode function are called with time_t now, but there is no encode/decode function created for time_t type. http://tracker.ceph.com/issues/5402 refs #5402 This patch adds a WRITE_RAW_ENCODER to support this type. -- Christophe Courtaut

PGLog API : missing

2013-06-20 Thread Loic Dachary
Hi Sam, I tried to consider the part of the API of PGLog related to pg_missing_t, looking at what it currently is and what it should be. At the moment it is ( not considering the methods that have a side effect on both missing and log ): Accessor: const pg_missing_t get_missing() const {

Re: [PATCH 1/2] Fscache glue implementation for Ceph

2013-06-20 Thread Sage Weil
On Wed, 19 Jun 2013, Milosz Tanski wrote: The facilities needed for fscache support support. This part of the work is self contained in it's files and just getting Ceph ready. Signed-off-by: Milosz Tanski mil...@adfin.com This file should be run through someting like scripts/Lindent to

Re: rbd: assertion failure in rbd_img_obj_callback()

2013-06-20 Thread Sage Weil
On Thu, 20 Jun 2013, Andreas Bluemle wrote: Hi, when working on a large rbd image, I am hitting an assertion failure in rbd kernel module; the assertion is in rbd_img_obj_callback() rbd_assert(img_request != NULL); The test is a sequential write on an rbd image, format 1.

Re: lost bugfix in sync_requester_abort?

2013-06-20 Thread Sage Weil
On Thu, 20 Jun 2013, Jim Schutt wrote: Hi Sage, A week or so ago you had a patch in your wip-mon branch (now gone) called mon: fix raw use of *_dout in sync_requester_abort(). It seems that patch got dropped. AFAICS, without that patch, sync_requester_abort() has different behavior

Re: [PATCH 1/2] Fscache glue implementation for Ceph

2013-06-20 Thread Milosz Tanski
On Thu, Jun 20, 2013 at 11:23 AM, Sage Weil s...@inktank.com wrote: On Wed, 19 Jun 2013, Milosz Tanski wrote: The facilities needed for fscache support support. This part of the work is self contained in it's files and just getting Ceph ready. Signed-off-by: Milosz Tanski mil...@adfin.com

Re: Comments on Ceph distributed parity implementation

2013-06-20 Thread Loic Dachary
On 06/18/2013 04:22 PM, James Plank wrote: Hi all -- thank you for including me on this thread, although I have little substantive to add. At the moment, my sole focus is finishing a journal paper about GF implementations, with a concomitant GF-complete release to accompany it. I agree

Re: [PATCH] rgw: Added an encoder for time_t to fix compilation

2013-06-20 Thread Yehuda Sadeh
On Thu, Jun 20, 2013 at 6:57 AM, christophe courtaut christophe.court...@gmail.com wrote: On the rgw-wip-geo-2 branch, the encode decode function are called with time_t now, but there is no encode/decode function created for time_t type. http://tracker.ceph.com/issues/5402 refs #5402 This

re: rbd: refactor rbd_header_from_disk()

2013-06-20 Thread Dan Carpenter
Hello Alex Elder, The patch bb23e37acb2a: rbd: refactor rbd_header_from_disk() from May 6, 2013, has some integer overflow bugs: drivers/block/rbd.c 793 snap_count = le32_to_cpu(ondisk-snap_count); 794 snapc = ceph_create_snap_context(snap_count, GFP_KERNEL); snap_count

Re: rbd: refactor rbd_header_from_disk()

2013-06-20 Thread Alex Elder
On 06/20/2013 04:11 PM, Dan Carpenter wrote: Hello Alex Elder, The patch bb23e37acb2a: rbd: refactor rbd_header_from_disk() from May 6, 2013, has some integer overflow bugs: drivers/block/rbd.c 793 snap_count = le32_to_cpu(ondisk-snap_count); 794 snapc =

RE: Comments on Ceph distributed parity implementation

2013-06-20 Thread Paul Von-Stamwitz
On 06/20/2013 11:26 PM, Loic Dachary wrote: I wrote down a short description of the read/write path I plan to implement in ceph : https://github.com/dachary/ceph/blob/wip-4929/doc/dev/osd_internals/erasure-code.rst. A quick look at the drawings will hopefully give you an idea. Each OSD is a

Re: [PATCH v2] Ceph: Punch hole support

2013-06-20 Thread Rob Landley
On 06/19/2013 11:23:51 AM, Li Wang wrote: This patch implements punch hole (fallocate) support for Ceph. Signed-off-by: Li Wang liw...@ubuntukylin.com Signed-off-by: Yunchuan Wen wenyunch...@ubuntukylin.com +static int ceph_delete_object(struct inode *inode, u64 offset, u64 *length) +{ +