Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-22 Thread Stefan Weil
Am 21.11.2012 21:53, schrieb Stefan Priebe - Profihost AG: Not sure about off_t. What is min and max size? Stefan off_t is a signed value which is used in function lseek to address any byte of a seekable file. The range is typically 64 bit

Re: [Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Stefan Weil
Am 22.11.2012 20:09, schrieb Stefan Priebe - Profihost AG: Hi Andreas, thanks for your comment. Do i have to resend this patch? -- Greets, Stefan Hi Stefan, I'm afraid yes, you'll have to resend the patch. Signed-off-by is a must, see http://wiki.qemu.org/Contribute/SubmitAPatch When you

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Weil
Am 20.11.2012 13:44, schrieb Stefan Priebe: rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. Signed-off-by: Stefan Priebe --- block/rbd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/rbd.