RE: format 2TB rbd device is too slow

2015-08-30 Thread Ma, Jianpeng
the time. For the -b of mkfs.xfs, I try for 65536. But it don't change any. Thanks! -Original Message- From: Ilya Dryomov [mailto:idryo...@gmail.com] Sent: Friday, August 28, 2015 5:23 PM To: Ma, Jianpeng Cc: huang jun; Haomai Wang; ceph-devel Subject: Re: format 2TB rbd device is too

RE: format 2TB rbd device is too slow

2015-08-28 Thread Ma, Jianpeng
Hi Ilya, We can change sector size from 512 to 4096. This can reduce the count of write. I did a simple test: for 900G, mkfs.xfs -f For default: 1m10s Physical sector size = 4096: 0m10s. But if change sector size, we need rbd meta record this. Thanks! Jianpeng -Original Message

RE: [PATCH] fs/ceph: No need get inode of parent in ceph_open.

2015-08-18 Thread Ma, Jianpeng
Thanks very much zheng. I'll pay more attention to the format of patch. Jianpeng -Original Message- From: Yan, Zheng [mailto:z...@redhat.com] Sent: Tuesday, August 18, 2015 10:36 AM To: Ma, Jianpeng Cc: Sage Weil; ceph-devel@vger.kernel.org Subject: Re: [PATCH] fs/ceph: No need

[PATCH] fs/ceph: No need get inode of parent in ceph_open.

2015-08-17 Thread Ma, Jianpeng
For ceph_open, it already get the parent inode. So no need to get again. Signed-off-by: Jianpeng Ma jianpeng...@intel.com --- fs/ceph/file.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 8b79d87..5ecd3dc 100644 --- a/fs/ceph/file.c +++ b/fs/ceph

[PATCH] fs/ceph: cleanup code.

2015-08-17 Thread Ma, Jianpeng
Signed-off-by: Jianpeng Ma jianpeng...@intel.com --- fs/ceph/mds_client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 6aa07af..0c65d77 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -2520,8 +2520,7

[PATCH ] fs/ceph: Remove the useless judgement.

2015-08-17 Thread Ma, Jianpeng
For ret != 0, it already handle. So skip this. Signed-off-by: Jianpeng Ma jianpeng...@intel.com --- fs/ceph/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 5ecd3dc..17cc357 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c

[PATCH] ceph: Using file-f_flags rather than flags check O_CREAT.

2015-08-13 Thread Ma, Jianpeng
Because flags removed the O_CREAT, so we should use file-f_flags. Signed-off-by: Jianpeng Ma jianpeng...@intel.com --- fs/ceph/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 8b79d87..e1347cf 100644 --- a/fs/ceph/file.c +++ b/fs

RE: [Questions]Can client know which OSDs are storing the data?

2015-01-26 Thread Ma, Jianpeng
-Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of Dennis Chen Sent: Tuesday, January 27, 2015 3:07 PM To: ceph-devel@vger.kernel.org; Dennis Chen Subject: [Questions]Can client know which OSDs are storing the data?

RE: Ceph data consistency

2015-01-06 Thread Ma, Jianpeng
of syncfs(). Jianpeng Ma Thanks! I was doing some experiments simulating disk errors using Device Mapper error target. In this setup OSD was writing to broken disk without crashing. Every 5 seconds (filestore_max_sync_interval) kernel logs that some data were discarded due to IO error

RE: Ceph data consistency

2015-01-06 Thread Ma, Jianpeng
Hi Sage, Pull request is https://github.com/ceph/ceph/pull/3305. Thanks! Jianpeng Ma -Original Message- From: Sage Weil [mailto:sw...@redhat.com] Sent: Wednesday, January 7, 2015 10:18 AM To: Ma, Jianpeng Cc: c...@sadziu.pl; vijayendra.shama...@sandisk.com; ceph-devel

Re: Question about Transaction::get_data_alignment

2014-11-05 Thread jianpeng
Hi sage: For #9661, i don't know the detail so i need time to understand this. Thanks Jianpeng -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

ceph.devel

2014-11-04 Thread jianpeng
subject all ceph-dev maillist -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: Latency Improvement Report for ShardedOpWQ

2014-09-28 Thread Ma, Jianpeng
Hi Somnath: You mentioned: There is still one global lock we have; this is to protect pg_for_processing() and this we can't get rid of since we need to maintain op order within a pg. But for most object operations, we only maintain the order of object. Why need maintain op order within a pg?

RE: [PATCH 2/3] ec: make use of added aligned buffers

2014-09-16 Thread Ma, Jianpeng
-Original Message- From: Loic Dachary [mailto:l...@dachary.org] Sent: Tuesday, September 16, 2014 2:47 PM To: Ma, Jianpeng Cc: ceph-devel@vger.kernel.org Subject: Re: [PATCH 2/3] ec: make use of added aligned buffers On 16/09/2014 02:08, Ma, Jianpeng wrote: -Original

RE: [PATCH 2/3] ec: make use of added aligned buffers

2014-09-16 Thread Ma, Jianpeng
I see it .Thanks very much! Jianpeng -Original Message- From: Loic Dachary [mailto:l...@dachary.org] Sent: Tuesday, September 16, 2014 3:55 PM To: Ma, Jianpeng Cc: ceph-devel@vger.kernel.org Subject: Re: [PATCH 2/3] ec: make use of added aligned buffers On 16/09/2014 08:59

RE: [PATCH 2/3] ec: make use of added aligned buffers

2014-09-15 Thread Ma, Jianpeng
If we modify bufferlist::c_str() to bufferlist::c_str(bool align). If (align) Posix_memalign(data, CEPH_PAGE_SIZE, len) Else Origin code. I think this is simple and correctly code. Jianpeng Thanks! -Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow

RE: [PATCH 2/3] ec: make use of added aligned buffers

2014-09-15 Thread Ma, Jianpeng
-Original Message- From: Sage Weil [mailto:sw...@redhat.com] Sent: Tuesday, September 16, 2014 8:02 AM To: Ma, Jianpeng Cc: Loic Dachary; Janne Grunau; ceph-devel@vger.kernel.org Subject: RE: [PATCH 2/3] ec: make use of added aligned buffers On Mon, 15 Sep 2014, Ma, Jianpeng wrote

RE: Deadlock in ceph journal

2014-08-24 Thread Ma, Jianpeng
don't use aio when closing journal. And using fsync(). It make the code simple. How about this? Thanks! Jianpeng ceph-devel@vger.kernel.org Subject: Re: Deadlock in ceph journal On 23/08/14 10:22, Somnath Roy wrote: I think it is using direct io for non-aio mode as well. Thanks

RE: Deadlock in ceph journal

2014-08-24 Thread Ma, Jianpeng
The attachment is the patch. Jianpeng -Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of Sage Weil Sent: Monday, August 25, 2014 10:15 AM To: Ma, Jianpeng Cc: Mark Kirkwood; Somnath Roy; Samuel Just (sam.j...@inktank.com

RE: Deadlock in ceph journal

2014-08-20 Thread Ma, Jianpeng
Yes, Maybe for io_submit, it must use io_getevent. Otherwise the result is undefined. If stop_write == true, we don't use aio. How about this way? Jianpeng -Original Message- From: Sage Weil [mailto:sw...@redhat.com] Sent: Wednesday, August 20, 2014 11:34 PM To: Somnath Roy Cc

RE: A bug in FileStore::mount and A problem about XFS

2014-08-14 Thread Ma, Jianpeng
I think you got the old code. I'm not find FX_TYPE_OTHER -Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of n...@cs.hku.hk Sent: Thursday, August 14, 2014 12:08 PM To: ceph-devel@vger.kernel.org Subject: A bug in

RE: ISA erasure code plugin and cache

2014-08-04 Thread Ma, Jianpeng
-Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of Loic Dachary Sent: Monday, August 4, 2014 8:37 PM To: Andreas Joachim Peters Cc: Ma, Jianpeng; Ceph Development Subject: Re: ISA erasure code plugin and cache

[PATCH]ECBackend: Don't directyly use get_recovery_chunk_size() in RecoveryOp::WRITING state.

2014-07-30 Thread Ma, Jianpeng
) [0x7f800997430d] NOTE: a copy of the executable, or `objdump -rdS executable` is needed to interpret this. So we only get the get_recovery_chunk_size() at RecoverOp::READING and record it using RecoveryOp::extent_requested. Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- src/osd/ECBackend.cc | 7

[PATCH]ECBackend: Using ROUND_UP_TO to refactor get_recovery_chunk_size()

2014-07-30 Thread Ma, Jianpeng
Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- src/osd/ECBackend.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/osd/ECBackend.h b/src/osd/ECBackend.h index 28bcf8a..0e96407 100644 --- a/src/osd/ECBackend.h +++ b/src/osd/ECBackend.h @@ -149,10 +149,8

RE: Pull Request for ISA EC plug-in

2014-07-30 Thread Ma, Jianpeng
Hi, At my machine, I also met this bug. But I modify this, it can work. diff --git a/src/erasure-code/isa/Makefile.am b/src/erasure-code/isa/Makefile.am index eebffea..dee593b 100644 --- a/src/erasure-code/isa/Makefile.am +++ b/src/erasure-code/isa/Makefile.am @@ -34,7 +34,7 @@

RE: [RFC][PATCH] osd: Add local_connection to fast_dispatch in func _send_boot.

2014-07-21 Thread Ma, Jianpeng
, the local-connection can add to dispatch. Maybe add ms_deliver_handle_fast_connect(local_connection.get()) in SimpleMessenger::ready is better. Jianpeng Ma I don't really see how supplying the local connection as a new one in _send_boot *should* be fixing that, and it's not the place to do so

[PATCH] os/FileJournal: When dump journal, using correctly last-seq avoid misjudging joural corrupt.

2014-07-21 Thread Ma, Jianpeng
In func FileJournal::dump, it always use seq=0 as last-seq and misjudge the journal corrupt. Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- src/os/FileJournal.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/os/FileJournal.cc b/src/os/FileJournal.cc index 7eb7927

RE: [RFC][PATCH] osd: Add local_connection to fast_dispatch in func _send_boot.

2014-07-16 Thread Ma, Jianpeng
Ping... -Original Message- From: ceph-devel-ow...@vger.kernel.org [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of Ma, Jianpeng Sent: Monday, July 14, 2014 11:17 AM To: g...@inktank.com Cc: ceph-devel@vger.kernel.org Subject: [RFC][PATCH] osd: Add local_connection to fast_dispatch

[PATCH] qa/workunits/erasure-code/bench.sh: Using correcting parameter name when call ceph_erasure_code_benchmark.

2014-07-15 Thread Ma, Jianpeng
In commit bcc74879a, loic modifed the parameter name. But he forgot to modify the name in qa/workunits/erasure-code/bench.sh. Now modify and make bench.sh work. Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- qa/workunits/erasure-code/bench.sh | 6 +++--- 1 file changed, 3 insertions(+), 3

[RFC][PATCH] osd: Add local_connection to fast_dispatch in func _send_boot.

2014-07-13 Thread Ma, Jianpeng
. For ECSubRead, it send to itself by func send_message_osd_cluster so it will cause this bug. I don't know about hb_back/front_server_messenger. But they are in _send_boot like cluster_messenger, so i also modified those. Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- src/osd/OSD.cc | 14

RE: [PATCH] ReplicatedPG: For async-read, set the real result after completing read.

2014-07-13 Thread Ma, Jianpeng
Hi Sam, I'm a newbie and I don’t have my ceph repo in github. So I can't send a full request. Jianpeng Ma Thanks! -Original Message- From: Samuel Just [mailto:sam.j...@inktank.com] Sent: Saturday, July 12, 2014 1:21 AM To: Ma, Jianpeng Cc: ceph-devel@vger.kernel.org Subject: Re

[PATCH] ReplicatedPG: For async-read, set the real result after completing read.

2014-07-10 Thread Ma, Jianpeng
When reading an object from replicated pool, ceph uses sync mode, so it can set the results in execute_ctx correctly. However, For the async-read in EC Pool, current code didn't set the real results after read in complete_read_ctx. Signed-off-by: Ma Jianpeng jianpeng...@intel.com --- src/osd

[PATCH] rbd.cc: Check io-size avoid floating point exception.

2014-06-12 Thread Ma, Jianpeng
In func do_bench_write if io_size is zero,it can cause floating point execption. Signed-off-by: Jianpeng Ma jianpeng...@intel.com --- src/rbd.cc | 8 1 file changed, 8 insertions(+) diff --git a/src/rbd.cc b/src/rbd.cc index d6658e3..c068ed6 100644 --- a/src/rbd.cc +++ b/src/rbd.cc