Re: [PATCH] fix librados aio read buffer handling

2013-12-30 Thread Josh Durgin
On 11/27/2013 12:49 AM, Rutger ter Borg wrote: On 2013-10-01 00:52, Josh Durgin wrote: I'm fine applying this now (with one fix). It's a nice cleanup even if things change more soon. For the C interface, the return value stored in the AioCompletionImpl needs to be the length read, so the calle

Re: [PATCH] fix librados aio read buffer handling

2013-11-27 Thread Rutger ter Borg
On 2013-10-01 00:52, Josh Durgin wrote: I'm fine applying this now (with one fix). It's a nice cleanup even if things change more soon. For the C interface, the return value stored in the AioCompletionImpl needs to be the length read, so the caller can tell if a short read occurred (this is onl

Re: [PATCH] fix librados aio read buffer handling

2013-09-30 Thread Sage Weil
On Mon, 30 Sep 2013, Josh Durgin wrote: > On 09/30/2013 08:38 AM, Sage Weil wrote: > > On Mon, 30 Sep 2013, Rutger ter Borg wrote: > > > > > > Dear all, > > > > > > please find attached a patch that enables a user to pass user-owned > > > buffers > > > into librados' aio_read. The patch (against

Re: [PATCH] fix librados aio read buffer handling

2013-09-30 Thread Josh Durgin
On 09/30/2013 08:38 AM, Sage Weil wrote: On Mon, 30 Sep 2013, Rutger ter Borg wrote: Dear all, please find attached a patch that enables a user to pass user-owned buffers into librados' aio_read. The patch (against dumpling) removes the buf and pbl data members in AioCompletionImpl. * The 'bu

Re: [PATCH] fix librados aio read buffer handling

2013-09-30 Thread Sage Weil
On Mon, 30 Sep 2013, Rutger ter Borg wrote: > > Dear all, > > please find attached a patch that enables a user to pass user-owned buffers > into librados' aio_read. The patch (against dumpling) removes the buf and pbl > data members in AioCompletionImpl. > > * The 'buf' argument to read() used t

[PATCH] fix librados aio read buffer handling

2013-09-30 Thread Rutger ter Borg
Dear all, please find attached a patch that enables a user to pass user-owned buffers into librados' aio_read. The patch (against dumpling) removes the buf and pbl data members in AioCompletionImpl. * The 'buf' argument to read() used to be passed into AioCompletionImpl, and the results wou