Re: [PATCH] rbd: fix module sysfs setup/teardown code

2012-03-02 Thread Sage Weil
Reviewed-by: Sage Weil On Tue, 28 Feb 2012, Alex Elder wrote: > Once rbd_bus_type is registered, it allows an "add" operation via > the /sys/bus/rbd/add bus attribute, and adding a new rbd device that > way establishes a connection between the device and rbd_root_dev. > But rbd_root_dev is not r

Re: [PATCH] rbd: fix module sysfs setup/teardown code

2012-02-29 Thread Alex Elder
On 02/29/2012 12:25 PM, Yehuda Sadeh Weinraub wrote: For consistency if (ret< 0) or change the previous one. OK. I will update. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] rbd: fix module sysfs setup/teardown code

2012-02-29 Thread Yehuda Sadeh Weinraub
On Tue, Feb 28, 2012 at 8:00 PM, Alex Elder wrote: > > Once rbd_bus_type is registered, it allows an "add" operation via > the /sys/bus/rbd/add bus attribute, and adding a new rbd device that > way establishes a connection between the device and rbd_root_dev. > But rbd_root_dev is not registered u

[PATCH] rbd: fix module sysfs setup/teardown code

2012-02-28 Thread Alex Elder
Once rbd_bus_type is registered, it allows an "add" operation via the /sys/bus/rbd/add bus attribute, and adding a new rbd device that way establishes a connection between the device and rbd_root_dev. But rbd_root_dev is not registered until after the rbd_bus_type registration is complete. This c