subject:"\[PATCH 0\/3\] libceph\: clean up some code involving CRCs"

Re: [PATCH 0/3] libceph: clean up some code involving CRCs

2012-03-02 Thread Alex Elder

On 03/02/2012 01:47 PM, Sage Weil wrote: These look good.. but where is the crc bug actually fixed? Not seeing that patch... I haven't addressed it yet. Soon, very soon... -Alex Reviewed-by: Sage Weil On Tue, 28 Feb 2012, Alex Elder wrote: Rename

Re: [PATCH 0/3] libceph: clean up some code involving CRCs

2012-03-02 Thread Sage Weil

These look good.. but where is the crc bug actually fixed? Not seeing that patch... Reviewed-by: Sage Weil On Tue, 28 Feb 2012, Alex Elder wrote: > Rename a few variables so it's clearer which indicate that a > CRC should be computed and which hold an actual CRC value. > Separate CRC calculat

[PATCH 0/3] libceph: clean up some code involving CRCs

2012-02-28 Thread Alex Elder

Rename a few variables so it's clearer which indicate that a CRC should be computed and which hold an actual CRC value. Separate CRC calculation from byte swapping to improve readability. And move some code that runs on only on the last pass through a couple of loops outside the loop body.