Re: [PATCH 2/2] rbd: prevent open for image being removed

2013-01-30 Thread Josh Durgin
Enums should be capitalized according to Documentation/CodingStyle. Other than that, looks good. Reviewed-by: Josh Durgin josh.dur...@inktank.com On 01/28/2013 02:09 PM, Alex Elder wrote: An open request for a mapped rbd image can arrive while removal of that mapping is underway. We need to

Re: [PATCH 2/2] rbd: prevent open for image being removed

2013-01-30 Thread Alex Elder
On 01/30/2013 01:52 PM, Josh Durgin wrote: Enums should be capitalized according to Documentation/CodingStyle. I already updated that in my own copy after last time... Thanks. -Alex Other than that, looks good. Reviewed-by: Josh Durgin

[PATCH 2/2] rbd: prevent open for image being removed

2013-01-28 Thread Alex Elder
An open request for a mapped rbd image can arrive while removal of that mapping is underway. We need to prevent such an open request from succeeding. (It appears that Maciej Galkiewicz ran into this problem.) Define and use a removing flag to indicate a mapping is getting removed. Set it in

[PATCH 2/2] rbd: prevent open for image being removed

2013-01-14 Thread Alex Elder
An open request for a mapped rbd image can arrive while removal of that mapping is underway. The control mutex and an open count is protect a mapped device that's in use from being removed. But it is possible for the removal of the mapping to reach the point of no return *after* a racing open