: [PATCH 3/4] fs: Remove i_size check from do_fallocate
Looks good, but the subject line is misleading, it should read something
like:
fs: move falloc collapse range check into the filesystem methods
Might also be worth mentioning that size checks for the other modes
are in the filesystems
On Tue, Apr 15, 2014 at 03:10:38PM +0200, Lukáš Czerner wrote:
I'll update the description and the subject.
Lukáš, FYI, I'm waiting for your update(s) to these patches in
response to Christoph's comments.
I'd like to push a set of bugfixes to Linus, hopefully this week so
they can make -rc2.
On Tue, Apr 15, 2014 at 06:09:34PM +0200, Lukáš Czerner wrote:
Ok, I'll run some tests and resend it right away without the patch
#4.
Thanks! So should I drop patch #4 for now? I don't think it does any
harm, and it does plug the hole somewhat, but Cristoph is right that
we still could have
Yes, please drop the patch #4 since it requires different solution, I
do not think it's critical enough to have partial solution and it has
been that way for a long time. We can fix it later.
Thanks!
-Lukas
Theodore Ts'o ty...@mit.edu wrote:
On Tue, Apr 15, 2014 at 06:09:34PM +0200,
On Sat, Apr 12, 2014 at 09:59:06AM -0400, Theodore Ts'o wrote:
On Fri, Apr 11, 2014 at 08:57:44PM +0200, Lukas Czerner wrote:
Currently in do_fallocate in collapse range case we're checking whether
offset + len is not bigger than i_size. However there is nothing which
would prevent i_size
On Fri, Apr 11, 2014 at 08:57:44PM +0200, Lukas Czerner wrote:
Currently in do_fallocate in collapse range case we're checking whether
offset + len is not bigger than i_size. However there is nothing which
would prevent i_size from changing so the check is pointless. It should
be done in the
Looks good, but the subject line is misleading, it should read something
like:
fs: move falloc collapse range check into the filesystem methods
Might also be worth mentioning that size checks for the other modes
are in the filesystems in the the long description.
Reviewed-by: Christoph Hellwig
Currently in do_fallocate in collapse range case we're checking whether
offset + len is not bigger than i_size. However there is nothing which
would prevent i_size from changing so the check is pointless. It should
be done in the file system itself and the file system needs to make sure
that
