Re: [PATCH 4/4] libceph: a few small changes

2012-03-02 Thread Sage Weil
On Tue, 28 Feb 2012, Alex Elder wrote: This gathers a number of very minor changes: - use %hu when formatting the a socket address's address family - null out the ceph_msgr_wq pointer after the queue has been destroyed - drop a needless cast in ceph_write_space() - add

Re: [PATCH 4/4] libceph: a few small changes

2012-03-02 Thread Alex Elder
On 03/02/2012 01:40 PM, Sage Weil wrote: + default: + WARN(1, unexpected socket state (%d), sk-sk_state); + break; } This is a red herring... the switch isn't meant to be exhaustive, only to catch the interesting (shutdown) states. I think #2099 can be

[PATCH 4/4] libceph: a few small changes

2012-02-28 Thread Alex Elder
This gathers a number of very minor changes: - use %hu when formatting the a socket address's address family - null out the ceph_msgr_wq pointer after the queue has been destroyed - drop a needless cast in ceph_write_space() - add a WARN() call in ceph_state_change() in the